Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is two parts here:
If I am correct,
marker.worldPos
=marker.origin
+ marker.rtcPos. Because the occlusion layers uses the
marker.originin the shader, the
marker.rtcPosshould be used to build positions instead of
marker.worldPos`.The commit XEOK-33 seems to introduce a bug in the occlusion tester because "OcclusionLayer markers' transformation is being applied through the OcclusionLayer::positions array" is not correct... ??