Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reduction agg with UDF #737

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

codingl2k1
Copy link
Contributor

What do these changes do?

Related issue number

Fixes #733

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added this to the v0.7.0 milestone Oct 9, 2023
@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #737 (3d39b25) into main (30cac74) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #737      +/-   ##
==========================================
- Coverage   93.55%   93.54%   -0.01%     
==========================================
  Files        1026     1026              
  Lines       79586    79586              
  Branches    16497    16497              
==========================================
- Hits        74456    74449       -7     
  Misses       3450     3450              
- Partials     1680     1687       +7     
Flag Coverage Δ
unittests 93.43% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
python/xorbits/_mars/dataframe/reduction/sum.py 100.00% <ø> (ø)

... and 12 files with indirect coverage changes

Copy link
Contributor

@aresnow1 aresnow1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aresnow1 aresnow1 merged commit 7ea4316 into xorbitsai:main Oct 10, 2023
29 of 31 checks passed
@luweizheng luweizheng mentioned this pull request Oct 13, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: user-defined function groupby.agg has unexpected keyword argument
3 participants