Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prevent title schema rewrites for custom titles #529

Merged
merged 5 commits into from
Mar 31, 2023
Merged

prevent title schema rewrites for custom titles #529

merged 5 commits into from
Mar 31, 2023

Conversation

bitshiftersgmbh
Copy link
Contributor

@bitshiftersgmbh bitshiftersgmbh commented Jan 26, 2023 •
edited by gharlan
Loading

if the user wants a custom title, he should get it exactly as is and nothing else

closes #528

@bitshiftersgmbh
prevent title schema rewrites for custom titles
248426c 
if the user wants a custom title, he should get it exactly as is and nothing else
@gharlan gharlan requested a review from tbaddade March 15, 2023 10:02
@bitshiftersgmbh
Update seo.php
7740cdb 
re-enabling replacement of %T and %SN, even for custom titles
@bitshiftersgmbh
Merge branch 'main' into patch-2
0b4e1a6
tbaddade
tbaddade approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@tbaddade tbaddade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ungetestet

gharlan
gharlan approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@gharlan gharlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ich habe es mir jetzt doch nochmal genauer angeschaut, und den Code insgesamt etwas umgestellt und damit verständlicher gemacht (wie ich finde).

@gharlan gharlan enabled auto-merge (squash) March 31, 2023 15:49
@gharlan gharlan merged commit 8986b39 into yakamara:main Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gharlan gharlan gharlan approved these changes

@tbaddade tbaddade tbaddade approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Eigener Title wendet Titel-Schema aus Profil an, sollte aber nicht so sein
3 participants
@bitshiftersgmbh @gharlan @tbaddade