Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YALB-1164 - OPAC: Update admin toolbar icons | 1461 - OPAC: Implement new admin colors and fonts #153

Merged
merged 11 commits into from
Jul 26, 2023

Conversation

@joetower joetower self-assigned this Jul 20, 2023
@joetower joetower marked this pull request as ready for review July 20, 2023 16:33
@joetower joetower changed the title Yalb 1164 1461 YALB-1164 - OPAC: Update admin toolbar icons | 1461 - OPAC: Implement new admin colors and fonts Jul 20, 2023
Copy link
Contributor

@codechefmarc codechefmarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to what Mike T. pointed out with "white" text over a while background, here are a few others I found:

  1. Status Report

Screenshot 2023-07-20 at 11 51 06 AM

  1. Appearance descriptions of themes

Screenshot 2023-07-20 at 11 52 21 AM

Also I wanted to point out the color difference of the buttons, not sure if that is something we want to change or not, but thought I'd point it out:

Screenshot 2023-07-20 at 11 51 21 AM

@joetower
Copy link
Contributor Author

@codechefmarc I pushed up fixes for your first two items.

I see your point about the buttons. My initial thought is that because that other instance of a button is on top of our --wool color, it should be different, for contrast. I'll see what Mike Tullo says. Maybe we should change it to use a dark gray, instead.

@dblanken-yale
Copy link
Contributor

Yes, the color differences on the buttons did stand out to me, especially the edit with the drop downs. The others didn't seem out of place to me.

@joetower
Copy link
Contributor Author

@dblanken-yale @codechefmarc What do you both think about changing them to the darkest gray?

Screenshot-20230721143033-2519x1281

Otherwise, we could go with the same light blue. I just feel like the buttons, when that small, feel washed out against the wool background.

Screenshot-20230721143355-2523x1327

What are your thoughts?

@dblanken-yale
Copy link
Contributor

We'll see what others say, but my vote is for the lighter color.

@joetower
Copy link
Contributor Author

@codechefmarc and @dblanken-yale This is ready for another look when you have time.

I did change the dropdown button to match the other buttons.

Could you please also add/edit content using layout-builder and make sure everything is legible.

Thank you!

Copy link
Contributor

@codechefmarc codechefmarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the others chimed in ahead of me - I poked around and it looked good to me, though I will have to admit that Mike Tullo is doing a great job at the details here. From what I saw, I'm approving.

@joetower joetower deleted the yalb-1164-1461 branch July 26, 2023 19:53
@nJim nJim mentioned this pull request Jul 31, 2023
@github-actions
Copy link

🎉 This PR is included in version 1.17.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants