-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YALB-1164 - OPAC: Update admin toolbar icons | 1461 - OPAC: Implement new admin colors and fonts #153
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to what Mike T. pointed out with "white" text over a while background, here are a few others I found:
- Status Report
- Appearance descriptions of themes
Also I wanted to point out the color difference of the buttons, not sure if that is something we want to change or not, but thought I'd point it out:
@codechefmarc I pushed up fixes for your first two items. I see your point about the buttons. My initial thought is that because that other instance of a button is on top of our |
Yes, the color differences on the buttons did stand out to me, especially the edit with the drop downs. The others didn't seem out of place to me. |
@dblanken-yale @codechefmarc What do you both think about changing them to the darkest gray? Otherwise, we could go with the same light blue. I just feel like the buttons, when that small, feel washed out against the wool background. What are your thoughts? |
We'll see what others say, but my vote is for the lighter color. |
@codechefmarc and @dblanken-yale This is ready for another look when you have time. I did change the dropdown button to match the other buttons. Could you please also add/edit content using layout-builder and make sure everything is legible. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the others chimed in ahead of me - I poked around and it looked good to me, though I will have to admit that Mike Tullo is doing a great job at the details here. From what I saw, I'm approving.
🎉 This PR is included in version 1.17.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
YALB-1164 - OPAC: Update admin toolbar icons | YALB-1461 - OPAC: Implement new admin colors and fonts
Description of work