Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YALB-1164 - OPAC: Update admin toolbar icons | 1461 - OPAC: Implement new admin colors and fonts #358

Merged
merged 22 commits into from
Jul 26, 2023

Conversation

joetower
Copy link
Contributor

@joetower joetower commented Jul 20, 2023

YALB-1164 - OPAC: Update admin toolbar icons | YALB-1461 - OPAC: Implement new admin colors and fonts

Description of work

  • Adds new icons for the admin toolbar
  • Implements new colors and fonts throughout the admin theme and frontend layout-builder

Functional testing steps:

Testing: YALB-1164 - OPAC: Update admin toolbar icons

  • Visit a page such as: https://pr-358-yalesites-platform.pantheonsite.io/components
  • Verify you see the new icons
  • Interact with the unpublish and publish button - note the icons change color. I used very slightly tinted green and red color values as more saturated colors would cause contrast issues.
yalb-1164-icons.mp4

Testing: YALB-1461 - OPAC: Implement new admin colors and fonts

yalb-1461-admin2.mp4
yalb-1461.mp4

@github-actions
Copy link

Visit Site

Created multidev environment pr-358 for yalesites-platform.

@joetower joetower changed the title Yalb 1164 1461 YALB-1164 - OPAC: Update admin toolbar icons | 1461 - OPAC: Implement new admin colors and fonts Jul 20, 2023
@joetower joetower self-assigned this Jul 20, 2023
@joetower joetower marked this pull request as ready for review July 20, 2023 16:33
@miketullo95
Copy link
Contributor

Hello! This is look great! I noticed in alert settings there seems to be some text color issues going on. Screenshot below.
Screen Shot 2023-07-20 at 1 15 00 PM
Will keep looking through to find more things

@joetower
Copy link
Contributor Author

@miketullo95 I pushed a fix up for the text issue on blocks, as you pointed out, and some additional fixes for the content creation pages.

I'm going to keep testing and fixing things locally, but please continue outlining anything else you notice. Thank you!

Copy link
Contributor

@dblanken-yale dblanken-yale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good. I'll let the others weigh in on contrast and the like, but I am not noticing any major issues.

@miketullo95
Copy link
Contributor

Morning! Here are a few small things:
On the media library, the toggle between grid and table may have some contrast issues
image
Media modal pagination
image
Not sure if this falls under this effort, but when selecting from the linkit module there is some funky color stuff here
image
button icon hover color in taxonomy manager
image
last one, again, might not be this effort specifically, but the yale icon seems to be cut-off now
image

@miketullo95
Copy link
Contributor

this looks great! last thing i noticed. In /layout we are getting the wool background on content areas which i think we just want white
image

@joetower
Copy link
Contributor Author

@miketullo95 Thank you!

This should be ready for a retest. Each item you referenced should be fixed (including the wool background change in layout-builder).

https://pr-358-yalesites-platform.pantheonsite.io

👍

@joetower
Copy link
Contributor Author

@miketullo95 Apologies, please hold off testing. I just saw one more item. I'll keep you posted. Thanks!

@joetower
Copy link
Contributor Author

@miketullo95 Okay, this should be ready to test again.

Please make sure to add/edit layout-builder content and make sure text renders as it should.

@miketullo95
Copy link
Contributor

Accordion items heading contrast:
Screen Shot 2023-07-25 at 8 57 51 AM
same issue, different area, on button link component:
Screen Shot 2023-07-25 at 9 01 19 AM
component item hover icon color contrast
Screen Shot 2023-07-25 at 9 02 21 AM
on smaller screen size, toolbar has odd color contrast
Screen Shot 2023-07-25 at 9 10 08 AM

I went through and added/edited all blocks in layout builder and there seems to be no rendering issues on my end

@joetower
Copy link
Contributor Author

@miketullo95 Awesome, thank you so much!

I pushed up fixes for each item. Could you please give this another look?

Thank you!

@miketullo95
Copy link
Contributor

text highlight color should have more contrast:
Screen Shot 2023-07-25 at 11 18 54 AM

One small suggestion - could we change gin-bg-app: to something lighter like #707070? (this passes a11y). In page setup and admin pages the dark color could be jarring to some, so hopefully making it lighter would be easier on the eyes and give some more distinction between the background and the admin bars.

@joetower
Copy link
Contributor Author

joetower commented Jul 25, 2023

@miketullo95 Are you saying that you'd like it to look something like this?

Screenshot-20230725103757-2552x1209

instead of this?
Screenshot-20230725103930-2559x1277

If this looks good I can double-check anywhere else (in our overrides) that may be using gin-bg-app and make that change.

@miketullo95
Copy link
Contributor

@joetower yeah, that looks great! And I think that is the last of my findings. After this change, this is approved from me 👍

@joetower
Copy link
Contributor Author

@miketullo95 Okay, this should be ready for another look. Thank you for all your testing on this. It's a big change. 👍

@miketullo95
Copy link
Contributor

It seems like on nodes im getting the wool color again :(
Screen Shot 2023-07-25 at 1 33 49 PM
on /edit I'm not tho
Screen Shot 2023-07-25 at 1 34 42 PM

@joetower
Copy link
Contributor Author

@miketullo95 Whoops! Looks like some overrides got removed. I added them back and things should be looking correct again. Apologies for that.

@miketullo95
Copy link
Contributor

no worries, this looks great! amazing work

@joetower joetower merged commit 7fefe04 into develop Jul 26, 2023
3 checks passed
@nJim nJim mentioned this pull request Jul 31, 2023
@nJim nJim mentioned this pull request Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants