Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(views-text): Change any/all text to not include category #761

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

dblanken-yale
Copy link
Contributor

@dblanken-yale dblanken-yale commented Sep 17, 2024

fix(views-text): Change any/all text to not include category

Because we have muiltiple places where Categories could be used, we don't want to specify that such that it's not misleading that this doesn't apply to the Jakala added filters.

Description of work

  • Changes the text displayed on the "Must include"/"Can include" to remove tags and category reference

Functional testing steps:

  • Add a view
  • Verify the text has changed

Because we have muiltiple places where Categories could be used, we
don't want to specify that such that it's not misleading that this
doesn't apply to the Jakala added filters.
Copy link
Contributor

@vinmassaro vinmassaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple text change LGTM

Copy link

Visit Site

Created multidev environment pr-761 for yalesites-platform.

@dblanken-yale dblanken-yale merged commit 1afa411 into v180 Sep 18, 2024
3 checks passed
@dblanken-yale dblanken-yale deleted the fix-views-text branch September 18, 2024 13:15
@yalesites yalesites mentioned this pull request Sep 18, 2024
@yalesites
Copy link

🎉 This PR is included in version 1.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants