Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(remove-exposed-filter-patch): Remove exposed filter patch #763

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

dblanken-yale
Copy link
Contributor

@dblanken-yale dblanken-yale commented Sep 18, 2024

Fix(remove-exposed-filter-patch): Remove exposed filter patch

Description of work

  • Removes "Ajax exposed filters not working for multiple instances of the same Views block placed on one page" patch

Functional testing steps:

  • Add an image block
  • Ensure when selecting media you can properly filter

Repercussion of removal test steps:

  • Add two views on a page with similar setups
  • After saving, filter the first view
  • Observe that the 2nd view received the filter the first view selected and the first view has a spinner waiting for it to finish (it never will)

Jakala is looking into a fix for this. Once we have a fix, we can introduce it.

Jakala relies on a patch that allows multiple views exposed filters to
apply solely on the view that initiated it.  Unfortunately, this
resulted in issues with the media filter not functioning properly and
providing an access denied on filter.  For now, we will remove this for
release while Jakala determines a new patch that could accomodate both
situations.
@dblanken-yale
Copy link
Contributor Author

@nplowman @marjina-constantin Wanted to ping you on this so you're aware.

Copy link
Contributor

@vinmassaro vinmassaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, LGTM

@dblanken-yale dblanken-yale merged commit 80f317a into v180 Sep 18, 2024
3 checks passed
@yalesites yalesites mentioned this pull request Sep 18, 2024
Copy link

Visit Site

Created multidev environment pr-763 for yalesites-platform.

@yalesites
Copy link

🎉 This PR is included in version 1.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants