Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

marked as deprecated options WithDatabase and WithEndpoint #1510

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

asmyasnikov
Copy link
Member

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@asmyasnikov asmyasnikov self-assigned this Oct 17, 2024
Copy link

summary

Base version: v3.84.2-0.20241015143341-dfe2ad80df18 (master)
Cannot suggest a release version.
Can only suggest a release version when compared against the most recent version of this major: v3.84.1.

@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.95%. Comparing base (dfe2ad8) to head (f2ccdaf).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1510      +/-   ##
==========================================
- Coverage   67.01%   66.95%   -0.06%     
==========================================
  Files         355      355              
  Lines       37006    37006              
==========================================
- Hits        24798    24776      -22     
- Misses      11106    11121      +15     
- Partials     1102     1109       +7     
Flag Coverage Δ
experiment 71.12% <ø> (-0.10%) ⬇️
go-1.21.x 67.20% <ø> (-0.11%) ⬇️
go-1.22.x 64.87% <ø> (-0.14%) ⬇️
go-1.23.x 66.93% <ø> (-0.08%) ⬇️
integration 53.36% <ø> (-0.10%) ⬇️
macOS 40.74% <ø> (ø)
ubuntu 71.27% <ø> (-0.07%) ⬇️
unit 41.16% <ø> (-0.02%) ⬇️
windows 41.16% <ø> (-0.02%) ⬇️
ydb-23.3 48.84% <ø> (-0.15%) ⬇️
ydb-24.1 53.29% <ø> (-0.13%) ⬇️
ydb-24.2 53.27% <ø> (-0.11%) ⬇️
ydb-nightly 71.12% <ø> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over table-service:

Grafana Dashboard

SLO-native-table

Copy link

🌋 Here are results of SLO test for Go SDK database/sql:

Grafana Dashboard

SLO-database-sql

Copy link

🌋 Here are results of SLO test for Go SDK gorm:

Grafana Dashboard

SLO-gorm

Copy link

🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over query-service:

Grafana Dashboard

SLO-native-query

Copy link

🌋 Here are results of SLO test for Go SDK xorm:

Grafana Dashboard

SLO-xorm

@asmyasnikov asmyasnikov merged commit 9c8cd67 into master Oct 17, 2024
43 of 44 checks passed
@asmyasnikov asmyasnikov deleted the deprecated branch October 17, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants