Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

marked as deprecated options WithDatabase and WithEndpoint #1510

Merged
merged 1 commit into from
Oct 17, 2024
Merged

marked as deprecated options WithDatabase and WithEndpoint #1510

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions options.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,8 @@ func WithConnectionTTL(ttl time.Duration) Option {
// Warning: use ydb.Open with required Driver string parameter instead
//
// For making Driver string from endpoint+database+secure - use sugar.DSN()
//
// Deprecated: use dsn parameter in Open method
func WithEndpoint(endpoint string) Option {
return func(ctx context.Context, c *Driver) error {
c.options = append(c.options, config.WithEndpoint(endpoint))
Expand All @@ -212,6 +214,8 @@ func WithEndpoint(endpoint string) Option {
// Warning: use ydb.Open with required Driver string parameter instead
//
// For making Driver string from endpoint+database+secure - use sugar.DSN()
//
// Deprecated: use dsn parameter in Open method
func WithDatabase(database string) Option {
return func(ctx context.Context, c *Driver) error {
c.options = append(c.options, config.WithDatabase(database))
Expand Down
Loading