#704 Enforce failure reasons in tests

[neonailol]

Implement #704 as suggested in #588

[0crat]

Job #744 is now in scope, role is REV

[0crat]

This pull request #744 is assigned to @fabriciofx/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @yegor256/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer

[codecov-io]

Codecov Report

Merging #744 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #744   +/-   ##
=========================================
  Coverage     78.82%   78.82%           
  Complexity     1180     1180           
=========================================
  Files           223      223           
  Lines          3367     3367           
  Branches        191      191           
=========================================
  Hits           2654     2654           
  Misses          666      666           
  Partials         47       47

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63f3b7f...7625549. Read the comment docs.

[0crat]

@fabriciofx/z this job was assigned to you 5 days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please.

[0crat]

@fabriciofx/z this job was assigned to you 8 days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please.

[0crat]

@fabriciofx/z this job was assigned to you 10days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please.

[0crat]

The user @fabriciofx/z resigned from #744, please stop working. Reason for job resignation: It is older than 10 days, see §8

[0crat]

Resigned on delay, see §8: -15 point(s) just awarded to @fabriciofx/z

[0crat]

This pull request #744 is assigned to @SharplEr/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @llorllale/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer

[SharplEr]

@neonailol Looks nice but as I understand I can't approve PR which builds with errors. I see only one way to solve it. You can add an empty string for all reasons of failure. After that, we can create an issue for adding the normal reasons. You can also use pdd, it is not hard, just look how people use it in jpeek project.
If you know about some other ways to fix build let me know.

[0crat]

@SharplEr/z this job was assigned to you 5days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please.

[SharplEr]

@llorllale the author doesn't react to my comment. How long should I wait?

[llorllale]

@SharplEr thanks

[SharplEr]

@llorllale You're welcome

[0crat]

@elenavolokhova/z please review this job completed by @SharplEr/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

[0crat]

The job #744 is now out of scope

[0crat]

Payment to ARC for a closed pull request, as in §28: +10 point(s) just awarded to @llorllale/z

[0crat]

The job is not in WBS, won't close the order

[elenavolokhova]

@0crat quality bad

[0crat]

Quality is low, no payment, see §31

[0crat]

Quality review completed: +8 point(s) just awarded to @elenavolokhova/z

[neonailol]

@SharplEr I think PR with errors is perfectly mergeable, as resolving this errors is not a part of the original task, as yegor said numerous times if 15 minutes not enough for completing a task, and you provide only tests it's perfectly fine

[SharplEr]

@neonailol I think just adding "" can't take a lot of time. And I always thought master should be valid anytime.
@llorllale Am I right about errors?

[llorllale]

@neonailol @SharplEr allowing a faulty build into master at this stage of the cactoos project will introduce too much noise and extra work. We have many contributors - we need a trustworthy build.