Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix QueryBuilderTest::testBatchInsert() #313

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Dec 6, 2023

Related with yiisoft/db#789

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues -

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b7bcc2b) 99.04% compared to head (ccb225f) 99.04%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #313   +/-   ##
=========================================
  Coverage     99.04%   99.04%           
  Complexity      174      174           
=========================================
  Files            13       13           
  Lines           524      524           
=========================================
  Hits            519      519           
  Misses            5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

what-the-diff bot commented Dec 6, 2023

PR Summary

  • Modification to 'testBatchInsert' method
    This change involves alteration of the testBatchInsert function in the QueryBuilderTest.php file. It now includes an extra parameter named $expectedParams. This parameter is then passed to the parent function, enhancing the capability of batch insert tests to provide more specific expected outcomes. This improves the effectiveness in testing different scenarios, ultimately benefiting the stability and reliability of the software.

@Tigrov Tigrov merged commit c9a8ce5 into master Dec 7, 2023
77 of 81 checks passed
@Tigrov Tigrov deleted the fix-query-builder-batch-insert-test branch December 7, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants