Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix QueryBuilderTest::testBatchInsert() #789

Merged
merged 4 commits into from
Dec 7, 2023

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Dec 6, 2023

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (199070f) 99.64% compared to head (6d46386) 99.64%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #789   +/-   ##
=========================================
  Coverage     99.64%   99.64%           
  Complexity     1265     1265           
=========================================
  Files            63       63           
  Lines          3063     3063           
=========================================
  Hits           3052     3052           
  Misses           11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

what-the-diff bot commented Dec 6, 2023

PR Summary

  • Enhancement on AbstractDMLQueryBuilder
    An improvement was made to the getTableUniqueColumnNames() function within the AbstractDMLQueryBuilder. This change removed some unnecessary operations to simplify the code and make it more efficient.

  • Updated testBatchInsert Parameter in Two PHP Files
    A new, optional parameter $expectedParams was added to the testBatchInsert() function in both the AbstractQueryBuilderTest.php and QueryBuilderTest.php files. This allows us to confirm that the parameters we're expecting are the ones actually being used.

  • Addition of Expected Parameters to batchInsert Data Provider
    The data provider batchInsert in the QueryBuilderProvider.php file was updated to include expected parameters. This strengthens our tests by ensuring the data we anticipate is the one being processed.

@Tigrov Tigrov added the status:code review The pull request needs review. label Dec 6, 2023
@Tigrov Tigrov requested a review from a team December 6, 2023 12:19
Copy link
Member

@vjik vjik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add line to changelog only

CHANGELOG.md Outdated Show resolved Hide resolved
@vjik vjik merged commit 447a0f0 into master Dec 7, 2023
84 of 87 checks passed
@vjik vjik deleted the fix-query-builder-batch-insert-test branch December 7, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants