Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix QueryBuilderTest::testBatchInsert() #283

Merged
merged 4 commits into from
Dec 7, 2023

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Dec 6, 2023

Related with yiisoft/db#789

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues -

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fd45a0b) 98.42% compared to head (38844f3) 98.42%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #283      +/-   ##
============================================
- Coverage     98.42%   98.42%   -0.01%     
+ Complexity      330      329       -1     
============================================
  Files            19       19              
  Lines          1016     1015       -1     
============================================
- Hits           1000      999       -1     
  Misses           16       16              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

what-the-diff bot commented Dec 6, 2023

PR Summary

  • Changed method signature in QueryBuilderTest.php
    The method testBatchInsert in QueryBuilderTest.php file has seen a modification in its list of parameters. Addition of expectedParams as a new input variable means developers can specify anticipated parameters for their test scenarios. By default, if no specifics are provided, an empty array will be used, ensuring that existing code behavior doesn't change. This change equips our team with more precise testing capabilities, ultimately leading to more robust and reliable code.

Copy link
Member

@vjik vjik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add line to changelog only

CHANGELOG.md Outdated Show resolved Hide resolved
@Tigrov Tigrov merged commit 0992809 into master Dec 7, 2023
19 of 21 checks passed
@Tigrov Tigrov deleted the fix-query-builder-batch-insert-test branch December 7, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants