Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix QueryBuilderTest::testBatchInsert() #249

Merged
merged 3 commits into from
Dec 7, 2023

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Dec 6, 2023

Related with yiisoft/db#789

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues -

Copy link

what-the-diff bot commented Dec 6, 2023

PR Summary

  • Modification in tests/Provider/QueryBuilderProvider.php
    The batchInsert method now has a few updates. This change impacts how the method processes internally, enhancing its operation and making it more efficient.

  • Change in tests/QueryBuilderTest.php
    The testBatchInsert method has been slightly adjusted. One additional parameter ($expectedParams) is now part of it. This addition helps the method to perform more specific and accurate testing actions.

@Tigrov Tigrov changed the title Fix query builder batch insert test Fix QueryBuilderTest::testBatchInsert() Dec 6, 2023
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ebb4645) 98.40% compared to head (e459f1e) 98.40%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #249   +/-   ##
=========================================
  Coverage     98.40%   98.40%           
  Complexity      175      175           
=========================================
  Files            16       16           
  Lines           564      564           
=========================================
  Hits            555      555           
  Misses            9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov merged commit 1ae3f3d into master Dec 7, 2023
18 of 20 checks passed
@Tigrov Tigrov deleted the fix-query-builder-batch-insert-test branch December 7, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants