Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move methods from command to abstract pdo command #278

Merged
merged 3 commits into from
Nov 7, 2023

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Nov 5, 2023

Related with yiisoft/db#770

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues -

Copy link

codecov bot commented Nov 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (11f981b) 98.46% compared to head (4e85b0e) 98.42%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #278      +/-   ##
============================================
- Coverage     98.46%   98.42%   -0.04%     
+ Complexity      342      332      -10     
============================================
  Files            19       19              
  Lines          1039     1018      -21     
============================================
- Hits           1023     1002      -21     
  Misses           16       16              
Files Coverage Δ
src/Command.php 98.59% <ø> (-0.33%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

what-the-diff bot commented Nov 5, 2023

PR Summary

  • Removal of unused import statements
    Certain import statements in the Command.php file were removed. These were originally meant for classes like PDOException, ConvertException, and QueryBuilderInterface which are not used in this file, making them unnecessary.

  • Deletion of getQueryBuilder() method
    The getQueryBuilder() method in the Command.php file was removed. This method was no longer in use and thus its presence in the codebase was not necessary.

  • Deletion of internalExecute() method
    Similarly, internalExecute() method in Command.php was also removed from this file as it had no current uses in the application.

These changes aim to make the codebase more maintainable, clean, and organized. The removal of unused declarations improves code readability and reduces the chance of complexity or confusion in the future.

@Tigrov Tigrov marked this pull request as ready for review November 5, 2023 07:34
@Tigrov Tigrov merged commit 26eaf4e into master Nov 7, 2023
19 checks passed
@Tigrov Tigrov deleted the move-methods-from-Command-to-AbstractPdoCommand branch November 7, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants