Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move methods from Command to AbstractPdoCommand class #770

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

Copy link

codecov bot commented Nov 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (39872b1) 99.05% compared to head (6cb6c07) 99.05%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #770   +/-   ##
=========================================
  Coverage     99.05%   99.05%           
- Complexity     1260     1270   +10     
=========================================
  Files            67       67           
  Lines          3059     3078   +19     
=========================================
+ Hits           3030     3049   +19     
  Misses           29       29           
Files Coverage Δ
src/Driver/Pdo/AbstractPdoCommand.php 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

what-the-diff bot commented Nov 5, 2023

PR Summary

  • Enhancement in Code Reusability
    Implemented an enhancement by moving specific methods from a distinct Command class to an abstract class (AbstractPdoCommand). This grants more flexibility and reuse of the methods across various parts of the application, ultimately leading to improved coding efficiency and reduced potential for errors.

  • Updated AbstractPdoCommand.php

    • Introduced a reference for QueryBuilderInterface class, which aids in building complex SQL queries in a more readable way.
    • Introduced a getQueryBuilder() method. This method enables easier and more efficient retrieval of the database connection's query builder, thereby simplifying database interaction.
    • Enhanced the internalExecute() method to include exception handling and retry capability. This improvement will enhance the system's resilience and reliability by ensuring operations are not immediately disrupted due to temporary issues, retrying operations where applicable.

@Tigrov Tigrov marked this pull request as ready for review November 5, 2023 07:34
@Tigrov Tigrov added the status:code review The pull request needs review. label Nov 5, 2023
@Tigrov Tigrov requested a review from a team November 5, 2023 07:36
@Tigrov Tigrov merged commit 735b456 into master Nov 7, 2023
86 of 87 checks passed
@Tigrov Tigrov deleted the move-methods-from-Command-to-AbstractPdoCommand branch November 7, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants