Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ColumnFactory #325

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Refactor ColumnFactory #325

wants to merge 2 commits into from

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Nov 2, 2024

Related PR

Q A
Is bugfix? ❌
New feature? ❌
Breaks BC? ✔️/❌
Fixed issues

@codecov Codecov
Copy link

codecov bot commented Nov 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.51%. Comparing base (953a1c5) to head (7a9d8a6).

Additional details and impacted files 
@@            Coverage Diff            @@
##             master     #325   +/-   ##
=========================================
  Coverage     98.51%   98.51%           
+ Complexity      340      337    -3     
=========================================
  Files            23       23           
  Lines          1074     1074           
=========================================
  Hits           1058     1058           
  Misses           16       16

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov mentioned this pull request Nov 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samdark samdark samdark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tigrov @samdark @StyleCIBot