Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor AbstractColumnFactory #897

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Refactor AbstractColumnFactory #897

wants to merge 2 commits into from

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Nov 2, 2024 •
edited
Loading

@codecov Codecov
Copy link

codecov bot commented Nov 2, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 99.60%. Comparing base (42181e1) to head (9119388).

Files with missing lines Patch % Lines
src/Schema/Column/AbstractColumnFactory.php 95.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##             master     #897   +/-   ##
=========================================
  Coverage     99.60%   99.60%           
- Complexity     1518     1525    +7     
=========================================
  Files            81       81           
  Lines          3753     3760    +7     
=========================================
+ Hits           3738     3745    +7     
  Misses           15       15

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This was referenced Nov 2, 2024
Open
Open
Open
Open
Open
@Tigrov Tigrov added the status:code review The pull request needs review. label Nov 2, 2024
@Tigrov Tigrov requested a review from a team November 2, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samdark samdark samdark approved these changes

Assignees
No one assigned
Labels
status:code review The pull request needs review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tigrov @samdark @StyleCIBot