Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix PXR_PLUGINPATH_NAME and path appending #5

Merged
merged 8 commits into from
Jun 11, 2024

Conversation

antirotor
Copy link
Member

This quick PR is fixing PXR_PLUGINPATH_NAME handling and path appending for PATH and PYTHONPATH

antirotor added 2 commits May 21, 2024 16:53
it needs to point to the directory, not to the json file itself
@antirotor antirotor requested a review from a user May 21, 2024 15:24
@antirotor antirotor self-assigned this May 21, 2024
@antirotor antirotor added the type: bug Something isn't working label May 21, 2024
Copy link
Collaborator

@Lypsolon Lypsolon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also would like to mention that this error appears at launcher startup.

Traceback (most recent call last):
  File "/home/lyonh/ynput/DevEnv/projects/AyonCore/ayon-core/client/ayon_core/addon/base.py", line 1446, in start_addons
    addon.tray_start()
  File "/home/lyonh/.local/share/AYON/addons/ayon_usd_1.0.2/ayon_usd/addon.py", line 37, in tray_start
    download_usd = is_usd_download_needed()
  File "/home/lyonh/.local/share/AYON/addons/ayon_usd_1.0.2/ayon_usd/utils.py", line 207, in is_usd_download_needed
    usd_root = get_downloaded_usd_root()
  File "/home/lyonh/.local/share/AYON/addons/ayon_usd_1.0.2/ayon_usd/utils.py", line 181, in get_downloaded_usd_root
    if existing_info["checksum"] != server_usd_info["checksum"]:
TypeError: 'NoneType' object is not subscribable

client/ayon_usd/hooks/pre_resolver_init.py Outdated Show resolved Hide resolved
client/ayon_usd/hooks/pre_resolver_init.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@Lypsolon Lypsolon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested under Almlinux9
the only thing I needed to "hack in" was a "solution" for setting LD_LIBRARY_PATH because it's erroring if the key doesn't already exist (will be fixed with an issue and PR)

noice work.

Copy link
Collaborator

@Lypsolon Lypsolon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested Works for AlmaLinux9
lets merge this and close the other PR.

@antirotor antirotor merged commit 291b456 into develop Jun 11, 2024
1 check passed
@antirotor antirotor deleted the bugfix/fix-pxr_pluginpath_name branch June 11, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants