Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: setting vitest #6

Merged
merged 3 commits into from
May 29, 2024
Merged

chore: setting vitest #6

merged 3 commits into from
May 29, 2024

Conversation

Hanna922
Copy link
Member

1️⃣ 어떤 작업을 했나요? (Summary)

4️⃣ 체크리스트 (Checklist)

  • main 브랜치의 최신 코드를 pull 받았나요?

@Hanna922 Hanna922 added the chore label May 28, 2024
@Hanna922 Hanna922 requested review from owl1753 and intersoom May 28, 2024 14:24
@Hanna922 Hanna922 self-assigned this May 28, 2024
@@ -40,6 +42,7 @@
"@typescript-eslint/eslint-plugin": "^6.0.0",
"@typescript-eslint/parser": "^6.0.0",
"@vitejs/plugin-react-swc": "^3.3.2",
"@vitest/ui": "^1.6.0",
"eslint": "^8.45.0",
"eslint-config-prettier": "^9.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lint-config 브랜치에서는 루트의 lint 의존성들은 삭제 했는데 !
합치기 전에 여기서도 지워버릴까용?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

합치면서 컨플릭 해결하는 게 좋을 것 같아요!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넹 !!!!

@Hanna922 Hanna922 requested a review from intersoom May 29, 2024 08:03
@Hanna922 Hanna922 mentioned this pull request May 29, 2024
1 task
Copy link
Member

@intersoom intersoom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌🏻 짱,,~

Copy link
Collaborator

@owl1753 owl1753 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굳굳입니당! 궁금한 점이 있는데, 혹시 테스트를 패키지마다 별도로 실행하려면 어떻게 해야 할까요? 그리고 vitest-workspace라는 것도 있던데 pnpm-workspace나 turborepo처럼 monorepo를 위한 것인가요??

@Hanna922
Copy link
Member Author

@owl1753 해당 packages 의 packge.json에 test: vitest 스크립트를 지정하고, vitest.config.ts 를 설정한 뒤 동일하게 pnpm logging-system test 형태로 명령어 실행하시면 됩니다.
vitest-workspace 는 제가 설정한 부분이 아니라 저도 찾아봐야 할 것 같네용

@Hanna922 Hanna922 merged commit 8892e12 into main May 29, 2024
@Hanna922 Hanna922 deleted the chore/#5-vitest branch May 29, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: setting vitest
3 participants