Cherry pick PR #2454: Stabilize JavaScript Profiler in Cobalt #2548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marking as draft for now ( keeps the merge queue shorter ) |
b/323983545 A major refactor was needed in order to prevent the JavaScript Profiler from SEGFAULTING due to a garbage-collected nullptr. This refactor includes the use of a `ProfilerGroup` class. The life of a cobalt::js_profiler::Profiler is extended by adding scoped_refptrs to the ProfilerGroup; thus preventing GC. Profilers live as long as their ProfilerGroup, which lives as long as the Isolate and Web Agent. One `ProfilerGroup` is bound to one `web::Agent`, and contains one `v8::Isolate`, one `v8::CpuProfiler`, and many `cobalt::js_profiler::Profiler`s. The major advantage of this refactor is that it does not crash, and is more faithful to the [original Chromium Implementation](https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/timing/profiler_group.cc;bpv=0;bpt=0). Test-On-Device: true --------- Co-authored-by: Ahmed Elzeiny <[email protected]> (cherry picked from commit 84c616f)
aelzeiny
force-pushed
the
cherry-pick-24.lts.1+-2454
branch
from
9e24928
to
f598afe
Compare
|
Marking cherrypick as "ready for review". |
Refer to the original PR: #2569 b/326457979 This set of BlackBox tests causes Cobalt to SEGFAULT by forcing Garbage Collection to execute while the JS Profiler is running. It adds a new API to CrashLog called h5vcc.crashLog.forceGarbageCollection() for the purposes of testing. Reverts [an existing revert in PR 2567](#2567). Tests are rewritten to be less CPU-intensive; expecting fewer stack frames over a longer period of time. Test-On-Device: true --------- Co-authored-by: Kaido Kert <[email protected]> Co-authored-by: Ahmed Elzeiny <[email protected]> Co-authored-by: Brian Ting <[email protected]> Co-authored-by: Colin Liang <[email protected]> Co-authored-by: Bo-Rong Chen <[email protected]>
|
Merged "Cherry pick PR #2569: JavaScript Profiler Black box test" into this branch to ensure that both are shipped together. |
aelzeiny
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to the original PR: #2454
b/323983545
A major refactor was needed in order to prevent the JavaScript Profiler from SEGFAULTING due to a garbage-collected nullptr.
This refactor includes the use of a
ProfilerGroupclass. The life of a cobalt::js_profiler::Profiler is extended by adding scoped_refptrs to the ProfilerGroup; thus preventing GC. Profilers live as long as their ProfilerGroup, which lives as long as the Isolate and Web Agent. OneProfilerGroupis bound to oneweb::Agent, and contains onev8::Isolate, onev8::CpuProfiler, and manycobalt::js_profiler::Profilers.The major advantage of this refactor is that it does not crash, and is more faithful to the original Chromium Implementation.
Test-On-Device: true