Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick PR #2569: JavaScript Profiler Black box tests #2812

Merged
merged 11 commits into from
Apr 2, 2024

Conversation

cobalt-github-releaser-bot
Copy link
Collaborator

Refer to the original PR: #2569

b/326457979

This set of BlackBox tests causes Cobalt to SEGFAULT by forcing Garbage Collection to execute while the JS Profiler is running. It adds a new API to CrashLog called h5vcc.crashLog.forceGarbageCollection() for the purposes of testing. Reverts an existing revert in PR 2567. Tests are rewritten to be less CPU-intensive; expecting fewer stack frames over a longer period of time.

Test-On-Device: true

kaidokert and others added 11 commits March 26, 2024 13:38
…2721)

Refer to the original PR: #2689

Swaps Starboard's thread_sampler APIs for Android TV from stub to shared
implementations (`//starboard/shared/stub/thread_sampler_*` to
`//starboard/shared/pthread/thread_sampler_*`).

Tested on Android TV (x64), Google TV Emulator (arm64), and a real
Google TV device (arm).

Test-On-Device: true

b/330564529

Co-authored-by: Ahmed Elzeiny <[email protected]>
Preserves built APKs in a single bundle for all architectures.
This is intended to keep APKs with every release.

b/290121545
b/318577880

(cherry picked from commit ae41ccb)
Refer to the original PR: #2455

Preserves built APKs in a single bundle for all architectures.
This is intended to keep APKs with every release.
    
b/290121545
b/318577880
Refer to the original PR: #2763

This forces linux to build the loader_app_install,
elf_loader_sandbox_install, and native_target/crashpad_handler targets.

b/323963204

Co-authored-by: Brian Ting <[email protected]>
…et to null. (#2779)

Refer to the original PR: #2774

There is a race condition that the callback is triggered after
mMediaCodec is set to null.

b/331835987

Co-authored-by: Colin Liang <[email protected]>
Refer to the original PR: #2777

Reorder GitHub workflow steps so that Upload Nightly Artifacts occurs
after Build Bootloader is potentionally run so that the upload includes
the bootloaders.

b/323963204

---------

Co-authored-by: Brian Ting <[email protected]>
…eset() (#2506)

Refer to the original PR: #2501

1. When AdaptiveAudioDecoder() resets |audio_decoder_|, use
audio_decoder_->Reset() to reset |audio_decoder_|.
2. This PR makes all audio decoders using the same reset behavior.
3. The PR (#2287) revises the
reset behavior on android via flush MediaCodec. To align with this PR,
Cobalt resets the audio decoder via AudioDecoder::Reset() on other
platforms.

b/327229953

Co-authored-by: Bo-Rong Chen <[email protected]>
…rd_party/chromium/media (#2724)

Refer to the original PR: #2709

All modification to Chromium media code is guarded by `#if
defined(STARBOARD)`.

b/329702113

Co-authored-by: Bo-Rong Chen <[email protected]>
b/326457979

This set of BlackBox tests causes Cobalt to SEGFAULT by forcing Garbage
Collection to execute while the JS Profiler is running. It adds a new
API to CrashLog called h5vcc.crashLog.forceGarbageCollection() for the
purposes of testing. Reverts [an existing revert in PR
2567](#2567). Tests are rewritten
to be less CPU-intensive; expecting fewer stack frames over a longer
period of time.

Test-On-Device: true

---------

Co-authored-by: Ahmed Elzeiny <[email protected]>
(cherry picked from commit 30dacbc)
@aelzeiny aelzeiny changed the base branch from 24.lts.1+ to cherry-pick-24.lts.1+-2454 April 2, 2024 18:42
@aelzeiny
Copy link
Contributor

aelzeiny commented Apr 2, 2024

Update: please see #2548

This cherry-pick PR will be merged into the other branch to ensure that both pass tests and are shipped together

@aelzeiny aelzeiny merged commit 5b4837a into cherry-pick-24.lts.1+-2454 Apr 2, 2024
313 checks passed
@aelzeiny aelzeiny deleted the cherry-pick-24.lts.1+-2569 branch April 2, 2024 18:43
@aelzeiny aelzeiny restored the cherry-pick-24.lts.1+-2569 branch April 2, 2024 23:20
@aelzeiny aelzeiny deleted the cherry-pick-24.lts.1+-2569 branch April 3, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants