Update clang to upstream chromium m114's clang-17

[niranjanyardi]

b/323184809

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.86%. Comparing base (94df067) to head (c3c5032).
Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2680      +/-   ##
==========================================
+ Coverage   58.82%   58.86%   +0.03%     
==========================================
  Files        1906     1906              
  Lines       93605    93605              
==========================================
+ Hits        55060    55096      +36     
+ Misses      38545    38509      -36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[kaidokert]

Lets clean up the variable names so we don't have churn later.

I'd also consider reducing some duplication maybe, e.g. move the install code into a shared .sh file between the two containers, but that's up to you. It's more of a separate refactoring problem.

[niranjanyardi]

Lets clean up the variable names so we don't have churn later.

I'd also consider reducing some duplication maybe, e.g. move the install code into a shared .sh file between the two containers, but that's up to you. It's more of a separate refactoring problem.

done, will carry out the refactor in a follow up

addressed all changes

[kaidokert]

Looks okay - please be very careful while landing this, as it impacts a lot of containers.

[niranjanyardi]

Looks okay - please be very careful while landing this, as it impacts a lot of containers.

agreed, my plan is to test this out on internal builds before pushing with @briantting 's help.