Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag for partial audio frame support #2860

Merged
merged 3 commits into from
Jun 3, 2024

Conversation

kaidokert
Copy link
Member

Allow Starboard implementations to turn partial audio frames off.

b/324905656

Copy link

codecov bot commented Apr 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.79%. Comparing base (c8d3eac) to head (a8e7da2).

Current head a8e7da2 differs from pull request most recent head 83584cd

Please upload reports for the commit 83584cd to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2860      +/-   ##
==========================================
+ Coverage   57.86%   59.79%   +1.92%     
==========================================
  Files        1763     1825      +62     
  Lines       84639    88122    +3483     
==========================================
+ Hits        48979    52695    +3716     
+ Misses      35660    35427     -233     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kaidokert kaidokert requested review from isarkis and y4vor and removed request for isarkis April 6, 2024 22:58
starboard/CHANGELOG.md Show resolved Hide resolved
@kaidokert kaidokert enabled auto-merge (squash) June 1, 2024 01:08
auto-merge was automatically disabled June 3, 2024 18:00

Pull Request is not mergeable

Allow Starboard implementations to turn partial audio frames off.

b/324905656
@kaidokert kaidokert enabled auto-merge (squash) June 3, 2024 19:03
@kaidokert kaidokert disabled auto-merge June 3, 2024 19:13
@kaidokert kaidokert merged commit deb633e into youtube:main Jun 3, 2024
308 of 309 checks passed
@kaidokert kaidokert added the cp-25.lts.1+ Cherry Pick to the 25.lts.1+ branch label Jun 4, 2024
cobalt-github-releaser-bot pushed a commit that referenced this pull request Jun 4, 2024
Allow Starboard implementations to turn partial audio frames off.

b/324905656

(cherry picked from commit deb633e)
kaidokert added a commit that referenced this pull request Jun 4, 2024
Refer to the original PR: #2860

Allow Starboard implementations to turn partial audio frames off.

b/324905656

Co-authored-by: Kaido Kert <[email protected]>
@kaidokert kaidokert deleted the partial_audio branch June 30, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cp-25.lts.1+ Cherry Pick to the 25.lts.1+ branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants