[android] Disable failing WriteSingleBatch tests #3564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borongc
requested review from
sideb0ard,
jasonzhangxx,
xiaomings,
zhongqiliang and
osagie98
kaidokert
approved these changes
Jun 14, 2024
This PR (youtube#3325) changes SbPlayerGetMaximumNumberOfSamplesPerWrite() to 256 on ATV, but current testing files for SbPlayerWriteSampleTest.WriteSingleBatch tests are not long enough for the modification. Disable the tests and should be re-enabled once it fixes. b/347097484
kaidokert
force-pushed
the
disable_SbPlayerWriteSampleTest_WriteSingleBatch
branch
from
abc1900
to
bfcee4e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3564 +/- ##
==========================================
+ Coverage 58.75% 58.78% +0.03%
==========================================
Files 1781 1781
Lines 85266 85272 +6
==========================================
+ Hits 50096 50127 +31
+ Misses 35170 35145 -25 ☔ View full report in Codecov by Sentry. |
cobalt-github-releaser-bot
pushed a commit
that referenced
this pull request
Jun 14, 2024
This PR (#3325) changes SbPlayerGetMaximumNumberOfSamplesPerWrite() to 256 on ATV as Cobalt supports multiple samples per write to SbPlayer (b/227837774), but current testing files for SbPlayerWriteSampleTest.WriteSingleBatch tests are not long enough for the modification. Disable the tests and should be re-enabled once it fixes. b/347097484 (cherry picked from commit cc76a9c)
borongc
added a commit
that referenced
this pull request
Jun 14, 2024
#3567) Refer to the original PR: #3564 This PR (#3325) changes SbPlayerGetMaximumNumberOfSamplesPerWrite() to 256 on ATV as Cobalt supports multiple samples per write to SbPlayer (b/227837774), but current testing files for SbPlayerWriteSampleTest.WriteSingleBatch tests are not long enough for the modification. Disable the tests and should be re-enabled once it fixes. b/347097484 Co-authored-by: Bo-Rong Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR (#3325) changes SbPlayerGetMaximumNumberOfSamplesPerWrite() to 256 on ATV as Cobalt supports multiple samples per write to SbPlayer (b/227837774), but current testing files for SbPlayerWriteSampleTest.WriteSingleBatch tests are not long enough for the modification. Disable the tests and should be re-enabled once it fixes.
b/347097484