Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XB1 builders and runner #513

Closed
wants to merge 11 commits into from
Closed

Add XB1 builders and runner #513

wants to merge 11 commits into from

Conversation

isarkis
Copy link
Member

@isarkis isarkis commented Aug 10, 2023

b/266878119

@datadog-cobalt-youtube
Copy link

datadog-cobalt-youtube bot commented Aug 10, 2023

Datadog Report

Branch report: xb1
Commit report: b3757f8

cobalt_sandbox: 0 Failed, 0 New Flaky, 33835 Passed, 0 Skipped, 29m 13.03s Wall Time

@datadog-cobalt-youtube
Copy link

datadog-cobalt-youtube bot commented Aug 22, 2023

Datadog Report

Branch report: xb1
Commit report: f9f630e

cobalt_sandbox: 0 Failed, 0 New Flaky, 33883 Passed, 0 Skipped, 23m 48.96s Wall Time

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.17%. Comparing base (18ebe18) to head (d1663fc).
Report is 1378 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #513      +/-   ##
==========================================
+ Coverage   54.00%   55.17%   +1.16%     
==========================================
  Files         182      188       +6     
  Lines        3018     3389     +371     
==========================================
+ Hits         1630     1870     +240     
- Misses       1388     1519     +131     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@datadog-cobalt-youtube
Copy link

Datadog Report

Branch report: xb1
Commit report: 24efb51

cobalt_sandbox: 0 Failed, 0 New Flaky, 27483 Passed, 1 Skipped, 5m 23.58s Wall Time

@datadog-cobalt-youtube
Copy link

datadog-cobalt-youtube bot commented Oct 27, 2023

Datadog Report

Branch report: xb1
Commit report: c42690e

cobalt_sandbox: 0 Failed, 0 New Flaky, 29487 Passed, 1 Skipped, 11m 44.42s Wall Time

@oxve oxve force-pushed the main branch 2 times, most recently from 4fca35b to 2e8c30c Compare November 16, 2023 23:41
@TyHolc
Copy link
Contributor

TyHolc commented Jan 12, 2024

I finally got around to fixing my Docker issues locally and gave this a try. I initially got an error running with these Dockerfiles (same as b/255809507), but once the folder was created it built fine. I also tried running with @arjungm's changes at go/cobalt-cl/272980 and that worked as well.

@isarkis
Copy link
Member Author

isarkis commented Jan 12, 2024

go/cobalt-cl/272980

Should we rebase this PR and try running XB1 build again?

@TyHolc
Copy link
Contributor

TyHolc commented Jan 16, 2024

go/cobalt-cl/272980

Should we rebase this PR and try running XB1 build again?

Yeah, we can try that.

Even without that change though the compile failures from the previous build shouldn't be happening, and weren't happening locally.

@datadog-cobalt-youtube
Copy link

datadog-cobalt-youtube bot commented Jan 17, 2024

Datadog Report

Branch report: xb1
Commit report: d1663fc
Test service: cobalt_sandbox

✅ 0 Failed, 29855 Passed, 1 Skipped, 10m 9.26s Wall Time

TyHolc added a commit to TyHolc/cobalt that referenced this pull request Jan 25, 2024
See bug or youtube/cobalt_sandbox#513 for more
context.

b/266878119

Change-Id: Ib018dcd5d257c2c68cbb194f9867887ca1a4fdf6
Testing if github builds fail when we don't convert concurrent_links to
an int from a string. Locally this fails, but our CI may be configured
differently.
@isarkis isarkis requested a review from a team as a code owner January 29, 2024 21:26
TyHolc added a commit to youtube/cobalt that referenced this pull request Jan 30, 2024
See bug or youtube/cobalt_sandbox#513 for more
context.

b/266878119

Change-Id: Ib018dcd5d257c2c68cbb194f9867887ca1a4fdf6
cobalt-github-releaser-bot pushed a commit to youtube/cobalt that referenced this pull request Feb 27, 2024
See bug or youtube/cobalt_sandbox#513 for more
context.

b/266878119

Change-Id: Ib018dcd5d257c2c68cbb194f9867887ca1a4fdf6
(cherry picked from commit 7fff828)
kaidokert pushed a commit to kaidokert/cobalt_sandbox that referenced this pull request Mar 5, 2024
…ry network request. (youtube#513)

b/188060079

(cherry picked from commit 971be16)

Co-authored-by: Garo Bournoutian <[email protected]>
kaidokert pushed a commit to youtube/cobalt that referenced this pull request Mar 16, 2024
)

Refer to the original PR: #2296

See bug or youtube/cobalt_sandbox#513 for more
context.

b/266878119

Change-Id: Ib018dcd5d257c2c68cbb194f9867887ca1a4fdf6

---------

Co-authored-by: Tyler Holcombe <[email protected]>
Co-authored-by: Igor Sarkisov <[email protected]>
@kaidokert kaidokert closed this Sep 20, 2024
@kaidokert kaidokert deleted the xb1 branch September 20, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants