-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add XB1 builders and runner #513
Conversation
a82ffbd
to
b3757f8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #513 +/- ##
==========================================
+ Coverage 54.00% 55.17% +1.16%
==========================================
Files 182 188 +6
Lines 3018 3389 +371
==========================================
+ Hits 1630 1870 +240
- Misses 1388 1519 +131 ☔ View full report in Codecov by Sentry. |
4fca35b
to
2e8c30c
Compare
I finally got around to fixing my Docker issues locally and gave this a try. I initially got an error running with these Dockerfiles (same as b/255809507), but once the folder was created it built fine. I also tried running with @arjungm's changes at go/cobalt-cl/272980 and that worked as well. |
Should we rebase this PR and try running XB1 build again? |
Yeah, we can try that. Even without that change though the compile failures from the previous build shouldn't be happening, and weren't happening locally. |
Change to win64 based build b/266878119
See bug or youtube/cobalt_sandbox#513 for more context. b/266878119 Change-Id: Ib018dcd5d257c2c68cbb194f9867887ca1a4fdf6
Testing if github builds fail when we don't convert concurrent_links to an int from a string. Locally this fails, but our CI may be configured differently.
See bug or youtube/cobalt_sandbox#513 for more context. b/266878119 Change-Id: Ib018dcd5d257c2c68cbb194f9867887ca1a4fdf6
See bug or youtube/cobalt_sandbox#513 for more context. b/266878119 Change-Id: Ib018dcd5d257c2c68cbb194f9867887ca1a4fdf6 (cherry picked from commit 7fff828)
…ry network request. (youtube#513) b/188060079 (cherry picked from commit 971be16) Co-authored-by: Garo Bournoutian <[email protected]>
) Refer to the original PR: #2296 See bug or youtube/cobalt_sandbox#513 for more context. b/266878119 Change-Id: Ib018dcd5d257c2c68cbb194f9867887ca1a4fdf6 --------- Co-authored-by: Tyler Holcombe <[email protected]> Co-authored-by: Igor Sarkisov <[email protected]>
b/266878119