Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][broker]PIP-255 Add topic metrics for the number of production data requests to add a topic and the average number of messages per request. #6

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

yyj8
Copy link
Owner

@yyj8 yyj8 commented Apr 8, 2023

Motivation

In the current topic level monitoring, there is no metrics to monitor the number of send data requests and the number of messages per send request (i.e., each entry) for a topic. This is inconvenient for us to troubleshoot the following issues:

  1. In cases where the client does not perform batch data writing or the batch written messages are not very reasonable, we cannot intuitively reflect through monitoring and cannot detect unreasonable business usage in a timely manner; It has a significant impact on production and consumption performance, increasing cluster load, reducing cluster performance, and increasing overall costs;

  2. When we enable the production flow limiting strategy, if the flow limiting condition is triggered by the number of requests on a single connection, it is difficult to accurately locate which topic's high-frequency send data is causing it;

Modifications

Add four metrics:
pulsar_request_rate_in: Topic send request rate.
pulsar_average_msg_per_request: Average number of messages per send request for topic.

pulsar_producer_request_in: producer send request rate.
pulsar_producer_avg_msg_per_request: Average number of messages per send request for producer.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

… topic and the average number of messages per request.
@yyj8 yyj8 changed the title Add topic metrics for the number of production data requests to add a topic and the average number of messages per request. [improve][broker]PIP-255 Add topic metrics for the number of production data requests to add a topic and the average number of messages per request. Apr 8, 2023
… topic and the average number of messages per request.
… topic and the average number of messages per request.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant