Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI workflow for verifying no_std compatibility. #450

Merged
merged 1 commit into from
Dec 19, 2024

Add CI workflow for verifying no_std compatibility.

d983ca0
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Add CI workflow for verifying no_std compatibility. #450

Add CI workflow for verifying no_std compatibility.
d983ca0
Select commit
Loading
Failed to load commit list.
GitHub Actions / Clippy Result (stable) succeeded Dec 19, 2024 in 18s

Clippy (Stable ~ Linux/x86_64)

Clippy was successful!

Details

Running cargo clippy took roughly ~17511ms to complete

  • Working Directory: repository directory

Annotations

Check warning on line 642 in /home/runner/work/orchard/orchard/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Result (stable)

/home/runner/work/orchard/orchard/src/lib.rs#L642 

usage of `Iterator::fold` on a type that implements `Try`
Raw output 
warning: usage of `Iterator::fold` on a type that implements `Try`
   --> src/builder.rs:642:14
    |
642 |             .fold(Some(ValueSum::zero()), |acc, note_value| acc? + note_value)
    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `try_fold` instead: `try_fold(ValueSum::zero(), |acc, note_value| ...)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold
    = note: `#[warn(clippy::manual_try_fold)]` on by default

Check warning on line 816 in /home/runner/work/orchard/orchard/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Result (stable)

/home/runner/work/orchard/orchard/src/lib.rs#L816 

explicit call to `.into_iter()` in function argument accepting `IntoIterator`
Raw output 
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
   --> src/builder.rs:816:18
    |
816 |             .zip(indexed_outputs.into_iter())
    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `indexed_outputs`
    |
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
   --> /rustc/202008a1b8de96d2e5b6bc02d379db03a877d34d/library/core/src/iter/traits/iterator.rs:589:12
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
    = note: `#[warn(clippy::useless_conversion)]` on by default

Check warning on line 19 in /home/runner/work/orchard/orchard/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Result (stable)

/home/runner/work/orchard/orchard/src/lib.rs#L19 

doc list item without indentation
Raw output 
warning: doc list item without indentation
  --> src/bundle/commitments.rs:19:5
   |
19 | ///   with ZCASH_ORCHARD_ACTIONS_COMPACT_HASH_PERSONALIZATION
   |     ^^
   |
   = help: if this is supposed to be its own paragraph, add a blank line
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
   = note: `#[warn(clippy::doc_lazy_continuation)]` on by default
help: indent this line
   |
19 | ///    with ZCASH_ORCHARD_ACTIONS_COMPACT_HASH_PERSONALIZATION
   |       +

Check warning on line 21 in /home/runner/work/orchard/orchard/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Result (stable)

/home/runner/work/orchard/orchard/src/lib.rs#L21 

doc list item without indentation
Raw output 
warning: doc list item without indentation
  --> src/bundle/commitments.rs:21:5
   |
21 | ///   with ZCASH_ORCHARD_ACTIONS_MEMOS_HASH_PERSONALIZATION
   |     ^^
   |
   = help: if this is supposed to be its own paragraph, add a blank line
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
   |
21 | ///    with ZCASH_ORCHARD_ACTIONS_MEMOS_HASH_PERSONALIZATION
   |       +

Check warning on line 23 in /home/runner/work/orchard/orchard/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Result (stable)

/home/runner/work/orchard/orchard/src/lib.rs#L23 

doc list item without indentation
Raw output 
warning: doc list item without indentation
  --> src/bundle/commitments.rs:23:5
   |
23 | ///   with ZCASH_ORCHARD_ACTIONS_NONCOMPACT_HASH_PERSONALIZATION
   |     ^^
   |
   = help: if this is supposed to be its own paragraph, add a blank line
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
   |
23 | ///    with ZCASH_ORCHARD_ACTIONS_NONCOMPACT_HASH_PERSONALIZATION
   |       +

Check warning on line 24 in /home/runner/work/orchard/orchard/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Result (stable)

/home/runner/work/orchard/orchard/src/lib.rs#L24 

doc list item without indentation
Raw output 
warning: doc list item without indentation
  --> src/bundle/commitments.rs:24:5
   |
24 | /// as defined in [ZIP-244: Transaction Identifier Non-Malleability][zip244]
   |     ^
   |
   = help: if this is supposed to be its own paragraph, add a blank line
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
   |
24 | ///    as defined in [ZIP-244: Transaction Identifier Non-Malleability][zip244]
   |     +++

Check warning on line 181 in /home/runner/work/orchard/orchard/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Result (stable)

/home/runner/work/orchard/orchard/src/lib.rs#L181 

the following explicit lifetimes could be elided: 'a
Raw output 
warning: the following explicit lifetimes could be elided: 'a
   --> src/bundle.rs:181:14
    |
181 |         impl<'a, T: fmt::Debug> fmt::Debug for Actions<'a, T> {
    |              ^^                                        ^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
    = note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
    |
181 -         impl<'a, T: fmt::Debug> fmt::Debug for Actions<'a, T> {
181 +         impl<T: fmt::Debug> fmt::Debug for Actions<'_, T> {
    |

Check warning on line 252 in /home/runner/work/orchard/orchard/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Result (stable)

/home/runner/work/orchard/orchard/src/lib.rs#L252 

explicit call to `.into_iter()` in function argument accepting `IntoIterator`
Raw output 
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
   --> src/note_encryption.rs:252:18
    |
252 |             .zip(ephemeral_keys.into_iter())
    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `ephemeral_keys`
    |
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
   --> /rustc/202008a1b8de96d2e5b6bc02d379db03a877d34d/library/core/src/iter/traits/iterator.rs:589:12
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

Check warning on line 20 in /home/runner/work/orchard/orchard/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Result (stable)

/home/runner/work/orchard/orchard/src/lib.rs#L20 

the following explicit lifetimes could be elided: 'a
Raw output 
warning: the following explicit lifetimes could be elided: 'a
  --> src/pczt/updater.rs:20:6
   |
20 | impl<'a> Updater<'a> {
   |      ^^          ^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
   |
20 - impl<'a> Updater<'a> {
20 + impl Updater<'_> {
   |

Check warning on line 45 in /home/runner/work/orchard/orchard/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Result (stable)

/home/runner/work/orchard/orchard/src/lib.rs#L45 

the following explicit lifetimes could be elided: 'a
Raw output 
warning: the following explicit lifetimes could be elided: 'a
  --> src/pczt/updater.rs:45:6
   |
45 | impl<'a> ActionUpdater<'a> {
   |      ^^                ^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
   |
45 - impl<'a> ActionUpdater<'a> {
45 + impl ActionUpdater<'_> {
   |

Check warning on line 217 in /home/runner/work/orchard/orchard/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Result (stable)

/home/runner/work/orchard/orchard/src/lib.rs#L217 

usage of `Iterator::fold` on a type that implements `Try`
Raw output 
warning: usage of `Iterator::fold` on a type that implements `Try`
   --> src/value.rs:217:14
    |
217 |         iter.fold(Ok(ValueSum(0)), |acc, v| (acc? + *v).ok_or(OverflowError))
    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `try_fold` instead: `try_fold(ValueSum(0), |acc, v| ...)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold

Check warning on line 223 in /home/runner/work/orchard/orchard/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Result (stable)

/home/runner/work/orchard/orchard/src/lib.rs#L223 

usage of `Iterator::fold` on a type that implements `Try`
Raw output 
warning: usage of `Iterator::fold` on a type that implements `Try`
   --> src/value.rs:223:14
    |
223 |         iter.fold(Ok(ValueSum(0)), |acc, v| (acc? + v).ok_or(OverflowError))
    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `try_fold` instead: `try_fold(ValueSum(0), |acc, v| ...)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold
View more details on GitHub Actions