Refactoring a tiny portion of existing logic #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmassaki
reviewed
May 19, 2023
|
@mmassaki thank you! Is there a way to have someone from |
|
Sure, I just asked my team to have a look at this PR. |
xianlilow
approved these changes
May 25, 2023
Thank you so much for asking someone from your team to review this PR 🙏 What I actually meant to ask was if you could ask the Thank you again. |
|
All good. They will have a look as soon as they can. |
Shengming-Yan
approved these changes
May 26, 2023
added 2 commits
May 27, 2023 08:29
* Fix typo and rename the method to build_errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💐
/cc @zendesk/wattle
/cc @zendesk/vegemite
Description
This is a simple PR that refactors a tiny portion to reduce confusion.
References
Link to a JIRA or GitHub issue here if relevant
Before merging this PR
Risks