-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verify old password during password change #556
Conversation
✅ Deploy Preview for zenml-ui-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small comment, besides that testing worked fine for me 👍
@@ -69,42 +69,26 @@ export const PasswordPopup: React.FC<{ | |||
} else { | |||
setSubmitting(true); | |||
dispatch( | |||
loginAction({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just double checking, is it intended to remove this action here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the login action is no longer required, because the user update takes care of verifying that the current password supplied by the user matches the password in the database.
I regenerated the types, to be the latest ones, thats why the additions/deletions tend to look quite big |
The new password change workflow requires that the old password is verified during a password change. This PR updates the password change form to send the current password along to the API and at the same time removes the pre-check that runs the current password through the login endpoint to verify it, as that's no longer necessary.
Related to zenml-io/zenml#2587 changes in the API