Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify old password during password change #556

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

stefannica
Copy link
Contributor

@stefannica stefannica commented Apr 5, 2024

The new password change workflow requires that the old password is verified during a password change. This PR updates the password change form to send the current password along to the API and at the same time removes the pre-check that runs the current password through the login endpoint to verify it, as that's no longer necessary.

Related to zenml-io/zenml#2587 changes in the API

@CLAassistant
Copy link

CLAassistant commented Apr 5, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

netlify bot commented Apr 5, 2024

Deploy Preview for zenml-ui-dev ready!

Name Link
🔨 Latest commit 8e8be07
🔍 Latest deploy log https://app.netlify.com/sites/zenml-ui-dev/deploys/660fccb46ccd580008df398f
😎 Deploy Preview https://deploy-preview-556--zenml-ui-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@Cahllagerfeld Cahllagerfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment, besides that testing worked fine for me 👍

@@ -69,42 +69,26 @@ export const PasswordPopup: React.FC<{
} else {
setSubmitting(true);
dispatch(
loginAction({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just double checking, is it intended to remove this action here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the login action is no longer required, because the user update takes care of verifying that the current password supplied by the user matches the password in the database.

@Cahllagerfeld
Copy link
Contributor

I regenerated the types, to be the latest ones, thats why the additions/deletions tend to look quite big

@Cahllagerfeld Cahllagerfeld merged commit cc6eaab into dev Apr 8, 2024
7 of 8 checks passed
@Cahllagerfeld Cahllagerfeld deleted the bug/prd-353-verify-password-change branch April 8, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants