Check old password during password change and add missing CLI commands #2587

stefannica · 2024-04-04T17:34:45Z

Describe changes

As an extra security measure, this PR always requires that the current password value be supplied during a password change.

Additional related changes:

implement a separate zenml user change-password CLI command for changing the password for the current user
warn about passing passwords using command-line arguments in zenml user change-password, zenml user create and zenml user update
warn about using username/password to connect to a ZenML server and suggest using the web login flow or a service account API key instead
allow a user account to be activated and deactivated through zenml user update
implement the zenml user deactivate CLI command to be used to reset other user accounts through the CLI (by admins only).

IMPORTANT: this change invalidates the current ZenML Dashboard password change support. A dashboard update is required to pass the current password to the call made to the API (handled with zenml-io/zenml-dashboard#556)

Pre-requisites

Please ensure you have done the following:

I have read the CONTRIBUTING.md document.
If my change requires a change to docs, I have updated the documentation accordingly.
I have added tests to cover my changes.
I have based my new branch on develop and the open PR is targeting develop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.
If my changes require changes to the dashboard, these changes are communicated/requested.

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Other (add details above)

coderabbitai · 2024-04-04T17:34:50Z

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

…y-password-change

avishniakov

Thanks, nice feature!
Do we have dashboard changes ready? If not I would pause merging this, so it is not in the upcoming release, until Dashboard has this. @Cahllagerfeld

bcdurak

Thank you! The changes look good.

I just added a small comment for a minor QoL improvement (feel free to ignore).

I had the same question as @avishniakov. I am guessing the changes will go in once the dashboard is ready.

bcdurak · 2024-04-08T11:44:43Z

src/zenml/cli/user_management.py

+            hide_input=True,
+        )
+    if password is None:
+        password = click.prompt(


In many cases where I had to reset my password, I had to enter the new password twice. It is a nice mechanism to fight against the typos, perhaps we can also add it here?

Yes, great idea, I will add that.

stefannica · 2024-04-08T13:07:51Z

Thanks, nice feature! Do we have dashboard changes ready? If not I would pause merging this, so it is not in the upcoming release, until Dashboard has this. @Cahllagerfeld

@avishniakov yes, the dashboard changes have already been merged: zenml-io/zenml-dashboard#556

github-actions · 2024-04-08T13:24:45Z

E2E template updates in examples/e2e have been pushed.

github-actions · 2024-04-08T13:33:53Z

LLM Finetuning template updates in examples/llm_finetuning have been pushed.

github-actions · 2024-04-08T13:41:37Z

NLP template updates in examples/e2e_nlp have been pushed.

Check old password during password change and add missing CLI commands

Loading
Loading status checks…

d42cc03

stefannica added security P2 labels Apr 4, 2024

stefannica requested review from avishniakov and bcdurak April 4, 2024 17:34

github-actions bot added internal bug labels Apr 4, 2024

stefannica added the run-slow-ci label Apr 4, 2024

stefannica self-assigned this Apr 4, 2024

stefannica mentioned this pull request Apr 5, 2024

Verify old password during password change zenml-io/zenml-dashboard#556

Merged

stefannica added 2 commits April 5, 2024 10:07

Fix docstrings

Loading
Loading status checks…

91425ee

Merge remote-tracking branch 'origin/develop' into bug/ossk-501-verif…

Loading
Loading status checks…

5590b3c

…y-password-change

avishniakov approved these changes Apr 8, 2024

View reviewed changes

bcdurak approved these changes Apr 8, 2024

View reviewed changes

stefannica and others added 2 commits April 8, 2024 15:09

Ask to re-enter password during CLI password change

Loading
Loading status checks…

6bd4503

Auto-update of E2E template

Loading
Loading status checks…

792deb8

Auto-update of LLM Finetuning template

Loading
Loading status checks…

75a4196

Auto-update of NLP template

Loading
Loading status checks…

5e8122b

stefannica merged commit 58cb3d9 into develop Apr 9, 2024
5 checks passed

stefannica deleted the bug/ossk-501-verify-password-change branch April 9, 2024 07:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Check old password during password change and add missing CLI commands #2587

Check old password during password change and add missing CLI commands #2587

stefannica commented Apr 4, 2024 •

edited

Loading

coderabbitai bot commented Apr 4, 2024 •

edited

Loading

Auto Review Skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

avishniakov left a comment

bcdurak left a comment

bcdurak Apr 8, 2024

stefannica Apr 8, 2024

stefannica Apr 8, 2024

stefannica commented Apr 8, 2024

github-actions bot commented Apr 8, 2024

github-actions bot commented Apr 8, 2024

github-actions bot commented Apr 8, 2024

Check old password during password change and add missing CLI commands #2587

Check old password during password change and add missing CLI commands #2587

Conversation

stefannica commented Apr 4, 2024 • edited Loading

Describe changes

Pre-requisites

Types of changes

coderabbitai bot commented Apr 4, 2024 • edited Loading

Auto Review Skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

avishniakov left a comment

Choose a reason for hiding this comment

bcdurak left a comment

Choose a reason for hiding this comment

bcdurak Apr 8, 2024

Choose a reason for hiding this comment

stefannica Apr 8, 2024

Choose a reason for hiding this comment

stefannica Apr 8, 2024

Choose a reason for hiding this comment

stefannica commented Apr 8, 2024

github-actions bot commented Apr 8, 2024

github-actions bot commented Apr 8, 2024

github-actions bot commented Apr 8, 2024

stefannica commented Apr 4, 2024 •

edited

Loading

coderabbitai bot commented Apr 4, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)