drivers: wifi: nxp: Fix the compilation error on the MIMXRT1170_EVK board with the NXP_88W8987_MURATA_1ZM_M2 WiFi module #489
+162
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 17, 2024
| #if CONFIG_ZEPHYR | ||
| (void)OSA_EventNotifyPost(wm_wifi.wifi_core_task_Handle); | ||
| #ifdef __ZEPHYR__ | ||
| (void)OSA_TaskNotifyPost(wm_wifi.wifi_core_task_Handle); |
There was a problem hiding this comment.
please remove the non-zephyr part and remove #ifdef __ZEPHYR__
There was a problem hiding this comment.
Guess, as this is the original MCUx SDK code, it may contain non-Zephyr bare-metal code.
| @@ -45,6 +45,7 @@ | |||
| #define sdio_d(...) | |||
| #endif /* CONFIG_WIFI_SDIO_DEBUG */ | |||
|
|
|||
| #ifndef __ZEPHYR__ | |||
There was a problem hiding this comment.
if it's not used for zephyr, you can remove it
…oard with the NXP_88W8987_MURATA_1ZM_M2 WiFi module - Fix the compilation error on the MIMXRT1170_EVK board with the NXP_88W8987_MURATA_1ZM_M2 WiFi module Signed-off-by: Chen Shu <[email protected]>
|
I have removed the non-Zephyr parts and the #ifdef ZEPHYR as requested. Please review the changes. |
|
This time, I've kept the changes to a minimum and removed all unrelated modifications from the previous commits. I look forward to your review and approval. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
drivers: wifi: nxp: Fix the compilation error on the MIMXRT1170_EVK board with the NXP_88W8987_MURATA_1ZM_M2 WiFi module