subsys/bluetooth/host/classic/shell/bredr.c:440 space prohibited before that '++' (ctx:WxB)

subsys/bluetooth/host/classic/shell/bredr.c:521 space prohibited before that '++' (ctx:WxB)

Process completed with exit code 2.

See https://docs.zephyrproject.org/latest/contribute/guidelines.html#coding-style for more details. SPACING: space prohibited before that '++' (ctx:WxB) File:subsys/bluetooth/host/classic/shell/bredr.c Line:440 SPACING: space prohibited before that '++' (ctx:WxB) File:subsys/bluetooth/host/classic/shell/bredr.c Line:521

Process completed with exit code 1.

See https://docs.zephyrproject.org/latest/contribute/guidelines.html#clang-format for more details. You may want to run clang-format on this change: -#define BT_L2CAP_BR_FCS_NO 0x00 +#define BT_L2CAP_BR_FCS_NO 0x00 /** Frame Check Sequence type. 16-bit FCS. */ -#define BT_L2CAP_BR_FCS_16BIT 0x01 +#define BT_L2CAP_BR_FCS_16BIT 0x01 /** @brief BREDR L2CAP Endpoint structure. */ struct bt_l2cap_br_endpoint { /** Endpoint Channel Identifier (CID) */ - uint16_t cid; + uint16_t cid; /** Endpoint Maximum Transmission Unit */ - uint16_t mtu; -#if defined(CONFIG_BT_L2CAP_RET) || defined(CONFIG_BT_L2CAP_FC) || \ + uint16_t mtu; +#if defined(CONFIG_BT_L2CAP_RET) || defined(CONFIG_BT_L2CAP_FC) || \ defined(CONFIG_BT_L2CAP_ENH_RET) || defined(CONFIG_BT_L2CAP_STREAM) /** Endpoint Link Mode. * The value is defined as BT_L2CAP_BR_LINK_MODE_* */ - uint8_t mode; + uint8_t mode; File:include/zephyr/bluetooth/l2cap.h Line:265 You may want to run clang-format on this change: - bool optional; + bool optional; File:include/zephyr/bluetooth/l2cap.h Line:275 You may want to run clang-format on this change: - uint8_t transmit; + uint8_t transmit; /** Endpoint Retransmission Timeout * The field is configured by * `@kconfig{BT_L2CAP_BR_RET_TIMEOUT}` * The field should be no more than the field * `monitor_timeout`. */ - uint16_t ret_timeout; + uint16_t ret_timeout; /** Endpoint Monitor Timeout * The field is configured by * `@kconfig{BT_L2CAP_BR_MONITOR_TIMEOUT}` */ - uint16_t monitor_timeout; + uint16_t monitor_timeout; /** Endpoint Maximum PDU payload Size */ - uint16_t mps; + uint16_t mps; /** Endpoint Maximum Window Size * MAX supported window size is configured by * `@kconfig{BT_L2CAP_MAX_WINDOW_SIZE}`. The field * should be no more then `CONFIG_BT_L2CAP_MAX_WINDOW_SIZE`. */ - uint16_t window; + uint16_t window; File:include/zephyr/bluetooth/l2cap.h Line:303 You may want to run clang-format on this change: - uint8_t fcs; + uint8_t fcs; /** Endpoint Extended Control. * If this field is true, and both side support * `Extended Window size feature`, the local will * include `extended window size` option in configuration * request packet. */ - bool extended_control; + bool extended_control; File:include/zephyr/bluetooth/l2cap.h Line:321 You may want to run clang-format on this change: - struct bt_l2cap_chan chan; + struct bt_l2cap_chan chan; /** Channel Receiving Endpoint */ - struct bt_l2cap_br_endpoint rx; + struct bt_l2cap_br_endpoint rx; /** Channel Transmission Endpoint */ - struct bt_l2cap_br_endpoint tx; + struct bt_l2cap_br_endpoint tx; /* For internal use only */ - atomic_t flags[1]; - - bt_l2cap_chan_state_t state; + atomic_t flags[1]; + + bt_l2cap_chan_state_t state; /** Remote PSM to be connected */ - uint16_t psm; + uint16_t psm; /** Helps match request context during CoC */ - uint8_t ident; - bt_security_t required_sec_level; + uint8_t ident; + bt_security_t required_sec_level; /* Response Timeout eXpired (RTX) timer */ - struct k_work_delayable rtx_work; - struct k_work_sync rtx_sync; + struct k_work_delayable rtx_work; + struct k_work_sync rtx_sync; /** @internal To be used with @ref bt_conn.upper_data_ready */ - sys_snode_t _pdu_ready; + sys_snode_t _pdu_ready; /** @internal To be used with @ref bt_conn.upper_data_ready */ - atomic_t _pdu_ready_lock; + atomic_t _pdu_ready_lock; /** @internal List of net bufs not yet sent to lower layer */ - sy

include/zephyr/bluetooth/l2cap.h:265 -#define BT_L2CAP_BR_FCS_NO 0x00 +#define BT_L2CAP_BR_FCS_NO 0x00 /** Frame Check Sequence type. 16-bit FCS. */ -#define BT_L2CAP_BR_FCS_16BIT 0x01 +#define BT_L2CAP_BR_FCS_16BIT 0x01 /** @brief BREDR L2CAP Endpoint structure. */ struct bt_l2cap_br_endpoint { /** Endpoint Channel Identifier (CID) */ - uint16_t cid; + uint16_t cid; /** Endpoint Maximum Transmission Unit */ - uint16_t mtu; -#if defined(CONFIG_BT_L2CAP_RET) || defined(CONFIG_BT_L2CAP_FC) || \ + uint16_t mtu; +#if defined(CONFIG_BT_L2CAP_RET) || defined(CONFIG_BT_L2CAP_FC) || \ defined(CONFIG_BT_L2CAP_ENH_RET) || defined(CONFIG_BT_L2CAP_STREAM) /** Endpoint Link Mode. * The value is defined as BT_L2CAP_BR_LINK_MODE_* */ - uint8_t mode; + uint8_t mode;

include/zephyr/bluetooth/l2cap.h:275 - bool optional; + bool optional;

include/zephyr/bluetooth/l2cap.h:303 - uint8_t transmit; + uint8_t transmit; /** Endpoint Retransmission Timeout * The field is configured by * `@kconfig{BT_L2CAP_BR_RET_TIMEOUT}` * The field should be no more than the field * `monitor_timeout`. */ - uint16_t ret_timeout; + uint16_t ret_timeout; /** Endpoint Monitor Timeout * The field is configured by * `@kconfig{BT_L2CAP_BR_MONITOR_TIMEOUT}` */ - uint16_t monitor_timeout; + uint16_t monitor_timeout; /** Endpoint Maximum PDU payload Size */ - uint16_t mps; + uint16_t mps; /** Endpoint Maximum Window Size * MAX supported window size is configured by * `@kconfig{BT_L2CAP_MAX_WINDOW_SIZE}`. The field * should be no more then `CONFIG_BT_L2CAP_MAX_WINDOW_SIZE`. */ - uint16_t window; + uint16_t window;

include/zephyr/bluetooth/l2cap.h:321 - uint8_t fcs; + uint8_t fcs; /** Endpoint Extended Control. * If this field is true, and both side support * `Extended Window size feature`, the local will * include `extended window size` option in configuration * request packet. */ - bool extended_control; + bool extended_control;

include/zephyr/bluetooth/l2cap.h:408 - struct bt_l2cap_chan chan; + struct bt_l2cap_chan chan; /** Channel Receiving Endpoint */ - struct bt_l2cap_br_endpoint rx; + struct bt_l2cap_br_endpoint rx; /** Channel Transmission Endpoint */ - struct bt_l2cap_br_endpoint tx; + struct bt_l2cap_br_endpoint tx; /* For internal use only */ - atomic_t flags[1]; - - bt_l2cap_chan_state_t state; + atomic_t flags[1]; + + bt_l2cap_chan_state_t state; /** Remote PSM to be connected */ - uint16_t psm; + uint16_t psm; /** Helps match request context during CoC */ - uint8_t ident; - bt_security_t required_sec_level; + uint8_t ident; + bt_security_t required_sec_level; /* Response Timeout eXpired (RTX) timer */ - struct k_work_delayable rtx_work; - struct k_work_sync rtx_sync; + struct k_work_delayable rtx_work; + struct k_work_sync rtx_sync; /** @internal To be used with @ref bt_conn.upper_data_ready */ - sys_snode_t _pdu_ready; + sys_snode_t _pdu_ready; /** @internal To be used with @ref bt_conn.upper_data_ready */ - atomic_t _pdu_ready_lock; + atomic_t _pdu_ready_lock; /** @internal List of net bufs not yet sent to lower layer */ - sys_slist_t _pdu_tx_queue; - -#if defined(CONFIG_BT_L2CAP_RET) || defined(CONFIG_BT_L2CAP_FC) || \ + sys_slist_t _pdu_tx_queue; + +#if defined(CONFIG_BT_L2CAP_RET) || defined(CONFIG_BT_L2CAP_FC) || \ defined(CONFIG_BT_L2CAP_ENH_RET) || defined(CONFIG_BT_L2CAP_STREAM) /** @internal Total length of TX SDU */ - uint16_t _sdu_total_len; + uint16_t _sdu_total_len; /** @internal Holds the remaining length of current sending buffer */ - size_t _pdu_remaining; + size_t _pdu_remaining; /** @internal Holds the sending buffer. */ - struct net_buf *_pdu_buf; + struct net_buf *_pdu_buf; /** @internal TX windows for outstanding frame */ - sys_slist_t _pdu_outstanding; + sys_slist_t _pdu_outstanding; /** @internal PDU restore state */ - struct net_buf_simple_state _pdu_state; + struct net_buf_simple_state _pdu_state; /** @internal Free TX windows */ - struct k_fifo _free_tx_win; + struct k_fifo _free_tx_win; /** @internal TX windows */ - struct bt_l2cap_br_window tx_win[CONFIG_BT_L2CAP_MAX_WINDOW_SIZE]; + struct bt_l2cap_br_window tx_win[CONFIG_BT_L2CAP_MAX_WINDOW_SIZE]; /** Segment SDU packet from upper layer */ - struct net_buf *_sdu; + struct net_buf *_sdu; /** @internal RX SDU */ - uint16_t _sdu_len; + uint16_t _sdu_len; #if defined(CONFIG_BT_L2CAP_SEG_RECV) - uint16_t _sdu_len_done; + uint16_t _sdu_len_done; #endif /* CONFIG_BT_L2CAP_SEG_RECV */ -

include/zephyr/bluetooth/l2cap.h:425 - uint16_t tx_seq; + uint16_t tx_seq; /** @internal The sequence number to be used in the next new I-frame * transmitted. */ - uint16_t next_tx_seq; + uint16_t next_tx_seq; /** @internal The sequence number of the next I-frame expected to be * acknowledged by the receiving peer. */ - uint16_t expected_ack_seq; + uint16_t expected_ack_seq;

include/zephyr/bluetooth/l2cap.h:453 - uint16_t req_seq; + uint16_t req_seq; /** @internal The value of TxSeq expected in the next I-frame. */ - uint16_t expected_tx_seq; + uint16_t expected_tx_seq; /** @internal When segmented I-frames are buffered this is used to delay * acknowledgment of received I-frame so that new I-frame transmissions do * not cause buffer overflow. */ - uint16_t buffer_seq; + uint16_t buffer_seq; /** @internal States of Enhanced Retransmission Mode */ /** @internal Holds the number of times an S-frame operation is retried */ - uint16_t retry_count; + uint16_t retry_count; /** @internal save the ReqSeq of a SREJ frame */ - uint16_t srej_save_req_seq; + uint16_t srej_save_req_seq; /** @internal Retransmission Timer */ - struct k_work_delayable ret_work; + struct k_work_delayable ret_work; /** @internal Monitor Timer */ - struct k_work_delayable monitor_work; + struct k_work_delayable monitor_work;

subsys/bluetooth/host/classic/l2cap_br.c:36 -#if defined(CONFIG_BT_L2CAP_RET) || defined(CONFIG_BT_L2CAP_FC) || \ +#if defined(CONFIG_BT_L2CAP_RET) || defined(CONFIG_BT_L2CAP_FC) || \

subsys/bluetooth/host/classic/l2cap_br.c:50 -#define BR_CHAN_RET(_w) CONTAINER_OF(k_work_delayable_from_work(_w), \ - struct bt_l2cap_br_chan, ret_work) - -#define BR_CHAN_MONITOR(_w) CONTAINER_OF(k_work_delayable_from_work(_w), \ - struct bt_l2cap_br_chan, monitor_work) +#define BR_CHAN_RET(_w) \ + CONTAINER_OF(k_work_delayable_from_work(_w), struct bt_l2cap_br_chan, ret_work) + +#define BR_CHAN_MONITOR(_w) \ + CONTAINER_OF(k_work_delayable_from_work(_w), struct bt_l2cap_br_chan, monitor_work)