board: Google Twinkie V2 #54286

ualbertagreen · 2023-01-31T23:51:04Z

This is a new board for the google Twinkie V2 tool.

Signed-off-by: Jason Yuan [email protected]

jackrosenthal · 2023-01-31T23:55:31Z

boards/arm/google_twinkie_v2/google_twinkie_v2.dts

@@ -0,0 +1,195 @@
+/*
+ * Copyright 2022 The Chromium OS Authors


Copyright 2023 The ChromiumOS Authors - notice the year and no space in "ChromiumOS"

(Also elsewhere in this commit)

jackrosenthal · 2023-01-31T23:57:00Z

boards/arm/google_twinkie_v2/google_twinkie_v2_defconfig

+# Enable MPU
+CONFIG_ARM_MPU=y
+
+#CONFIG_USB_DEVICE_VID=18d1


why is this commented out?

jackrosenthal · 2023-01-31T23:57:14Z

samples/boards/google_pda/Kconfig

@@ -0,0 +1,22 @@
+# Private config options for eSPI sample app
+
+# Copyright (c) 2019 Intel Corporation


jackrosenthal · 2023-01-31T23:58:08Z

samples/boards/google_pda/src/crc32.c

+/* Constants matching USB3 and USB PD definitions */
+#define CRC32_INITIAL 0xFFFFFFFF
+
+/* Pre-computed values for polynom 0x04C11DB7 */


How can one re-compute these values?

jackrosenthal · 2023-02-01T00:00:06Z

samples/boards/google_pda/src/crc32.c

+	}
+
+	return crc;
+}


Zephyr already provides a CRC32 implementation: https://docs.zephyrproject.org/apidoc/latest/group__crc.html

Why does this need duplicated?

jackrosenthal · 2023-02-01T00:01:23Z

samples/boards/google_pda/src/shell.c

+		meas_vbus_c(&out);
+		shell_print(shell, "current of vbus: %i", out);
+	}
+	else {


Take a look at the style guide ... else must be cuddled. clang-format can fix this automatically for you.

boards/arm/google_twinkie_v2/Kconfig.defconfig

jackrosenthal · 2023-02-01T00:04:41Z

samples/boards/google_pda/src/view.c

+
+	smf_set_initial(SMF_CTX(&view_obj), &view_states[SNOOP0]);
+
+        while(1) {


see the style guide, space is always required after while.

clang-format can fix this automatically for you.

samples/boards/google_pda/src/view.c

jackrosenthal · 2023-02-01T00:05:44Z

samples/boards/google_pda/src/view.c

+	ret = gpio_pin_configure_dt(&led2, GPIO_OUTPUT_ACTIVE);
+	if (ret < 0) {
+		return ret;
+	}


same here, this should be a loop

fabiobaltieri · 2023-02-01T00:11:48Z

Hey @ualbertagreen, I don't really think that the application code belong to the sample/ directory here in the upstream repo. That's really meant for code demonstrating a specific functionality or API. The board should be fine though, how about you keep this PR for adding the board and move the application in a separate repository under the Google org? There's an example on how to setup a standalone application:

https://github.com/zephyrproject-rtos/example-application/

also check out https://zmk.dev/docs/development/setup, their setup has shallow clone and module filtering which you may find useful: https://github.com/zmkfirmware/zmk/blob/main/app/west.yml

boards/arm/google_twinkie_v2/Kconfig.board

boards/arm/google_twinkie_v2/Kconfig.defconfig

boards/arm/google_twinkie_v2/Kconfig.board

boards/arm/google_twinkie_v2/board.cmake

boards/arm/google_twinkie_v2/google_twinkie_v2.dts

boards/arm/google_twinkie_v2/google_twinkie_v2.yaml

boards/arm/google_twinkie_v2/google_twinkie_v2_defconfig

dts/bindings/adc/shunt-sensor.yaml

fabiobaltieri

Well I guess we are waiting for #54634 for the shut commit, should defo not be here.

In the meantime, the board should get some basic documentation as well, just realized it's missing, could you add some? (look for other boards as reference)

ualbertagreen · 2023-02-23T22:50:35Z

Well I guess we are waiting for #54634 for the shut commit, should defo not be here.

In the meantime, the board should get some basic documentation as well, just realized it's missing, could you add some? (look for other boards as reference)

@fabiobaltieri @galak I've moved #54634 in here as a stacked PR to avoid potential confusion. They are still kept as separate commits with separate commit messages so everything's compartmentalized.

I'll also add another commit stacked on top of this PR with a small app in samples/ that simply reads the voltage/current sensors and toggles the LED to show an example of how the sensor binding and board devicetree files are to be used. That way we can keep the full Twinkie app as a separate repository. Does that sound good with everyone?

ualbertagreen · 2023-06-27T21:30:22Z

Hi @fabiobaltieri @galak @jackrosenthal, the sensor PR has finally been merged. Could you take a look again at this PR. Just a reminder since it's been a while, this is the PR for the Twinkie V2 board and a sample code demonstrating its ability to snoop the usb-c lines. Thanks.

fabiobaltieri

Thanks for your patience, just few nitpicks, mostly cosmetic.

boards/arm/google_twinkie_v2/board.cmake

boards/arm/google_twinkie_v2/doc/index.rst

boards/arm/google_twinkie_v2/google_twinkie_v2.dts

samples/boards/google_twinkie_v2_pda/src/view.c

Dropping Kumar blocker since the DT changes are gone.

fabiobaltieri · 2023-07-07T09:33:40Z

Heya, I think you accidentally pushed some changes of the first commit into the second one.

ualbertagreen · 2023-07-07T21:35:26Z

Heya, I think you accidentally pushed some changes of the first commit into the second one.

Sorry about that, it should be fixed now.

fabiobaltieri · 2023-07-08T12:23:28Z

Heya, I think you accidentally pushed some changes of the first commit into the second one.

Sorry about that, it should be fixed now.

Yup no prob, happens to me all the time as well. There's still a couple of unresolved comments, all nitpicky, doule blank lines, odd property ordering etc, could you have a look at those? Happy with it after those.

samples/boards/google_twinkie_v2_pda/src/view.c

boards/arm/google_twinkie_v2/google_twinkie_v2.yaml

This is a new board for the google Twinkie V2 tool. Signed-off-by: Jason Yuan <[email protected]>

sample firmware for Twinkie V2 that toggles the LED based on charging status. Signed-off-by: Jason Yuan <[email protected]>

Addressed

ualbertagreen requested review from nashif and jackrosenthal as code owners January 31, 2023 23:51

zephyrbot requested review from fabiobaltieri and keith-zephyr January 31, 2023 23:51

zephyrbot assigned fabiobaltieri Jan 31, 2023

jackrosenthal requested changes Feb 1, 2023

View reviewed changes

ualbertagreen force-pushed the twinkie_v2-no_share_isr-2 branch 2 times, most recently from 662c73b to 7f98968 Compare February 1, 2023 00:33

ualbertagreen changed the title ~~Firmware for Google Twinkie V2.~~ board: Google Twinkie V2 Feb 1, 2023

ualbertagreen force-pushed the twinkie_v2-no_share_isr-2 branch 5 times, most recently from 6c0ebfd to 726b291 Compare February 1, 2023 21:21

fabiobaltieri reviewed Feb 2, 2023

View reviewed changes

boards/arm/google_twinkie_v2/google_twinkie_v2_defconfig Outdated Show resolved Hide resolved

ualbertagreen force-pushed the twinkie_v2-no_share_isr-2 branch 2 times, most recently from 17da79c to d31b74e Compare February 7, 2023 23:01

ualbertagreen requested a review from galak as a code owner February 7, 2023 23:01

zephyrbot added the area: Devicetree Binding PR modifies or adds a Device Tree binding label Feb 7, 2023

ualbertagreen force-pushed the twinkie_v2-no_share_isr-2 branch 2 times, most recently from 5907627 to d1dec09 Compare February 8, 2023 00:14

fabiobaltieri reviewed Feb 8, 2023

View reviewed changes

dts/bindings/adc/shunt-sensor.yaml Outdated Show resolved Hide resolved

ualbertagreen force-pushed the twinkie_v2-no_share_isr-2 branch 3 times, most recently from 71119ac to 43f7b4a Compare February 23, 2023 03:44

fabiobaltieri requested changes Feb 23, 2023

View reviewed changes

ualbertagreen mentioned this pull request Feb 23, 2023

dts: bindings: adc: add shunt sensor #54634

Closed

ualbertagreen force-pushed the twinkie_v2-no_share_isr-2 branch 3 times, most recently from 9557d88 to 65cf6e8 Compare June 27, 2023 21:07

fabiobaltieri reviewed Jul 3, 2023

View reviewed changes

ualbertagreen force-pushed the twinkie_v2-no_share_isr-2 branch 2 times, most recently from fb10b29 to 0d74da1 Compare July 6, 2023 23:04

ualbertagreen force-pushed the twinkie_v2-no_share_isr-2 branch 2 times, most recently from 1a85ad1 to de15ad6 Compare July 7, 2023 20:41

ualbertagreen force-pushed the twinkie_v2-no_share_isr-2 branch from de15ad6 to 9924536 Compare July 10, 2023 20:36

fabiobaltieri reviewed Jul 10, 2023

View reviewed changes

samples/boards/google_twinkie_v2_pda/src/view.c Outdated Show resolved Hide resolved

ualbertagreen force-pushed the twinkie_v2-no_share_isr-2 branch from 9924536 to 62977b0 Compare July 10, 2023 20:45

fabiobaltieri previously approved these changes Jul 10, 2023

View reviewed changes

fabiobaltieri requested a review from jackrosenthal July 10, 2023 20:57

jackrosenthal previously approved these changes Jul 18, 2023

View reviewed changes

str4t0m previously requested changes Jul 18, 2023

View reviewed changes

boards/arm/google_twinkie_v2/google_twinkie_v2.yaml Outdated Show resolved Hide resolved

ualbertagreen added 2 commits July 19, 2023 13:13

board: Google Twinkie V2

9aeb1a3

This is a new board for the google Twinkie V2 tool. Signed-off-by: Jason Yuan <[email protected]>

samples: boards: firmware for Twinkie V2

344f18b

sample firmware for Twinkie V2 that toggles the LED based on charging status. Signed-off-by: Jason Yuan <[email protected]>

ualbertagreen dismissed stale reviews from jackrosenthal and fabiobaltieri via 344f18b July 19, 2023 20:14

ualbertagreen force-pushed the twinkie_v2-no_share_isr-2 branch from 62977b0 to 344f18b Compare July 19, 2023 20:14

fabiobaltieri approved these changes Jul 19, 2023

View reviewed changes

sambhurst approved these changes Jul 25, 2023

View reviewed changes

jackrosenthal approved these changes Jul 25, 2023

View reviewed changes

carlescufi merged commit ad555d0 into zephyrproject-rtos:main Jul 25, 2023
15 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

board: Google Twinkie V2 #54286

board: Google Twinkie V2 #54286

ualbertagreen commented Jan 31, 2023 •

edited

Loading

jackrosenthal Jan 31, 2023

jackrosenthal Jan 31, 2023

jackrosenthal Jan 31, 2023

jackrosenthal Jan 31, 2023

jackrosenthal Feb 1, 2023

jackrosenthal Feb 1, 2023

jackrosenthal Feb 1, 2023

jackrosenthal Feb 1, 2023

fabiobaltieri commented Feb 1, 2023 •

edited

Loading

fabiobaltieri left a comment

ualbertagreen commented Feb 23, 2023

ualbertagreen commented Jun 27, 2023

fabiobaltieri left a comment

fabiobaltieri commented Jul 7, 2023

ualbertagreen commented Jul 7, 2023

fabiobaltieri commented Jul 8, 2023

		@@ -0,0 +1,22 @@
		# Private config options for eSPI sample app

		# Copyright (c) 2019 Intel Corporation


		smf_set_initial(SMF_CTX(&view_obj), &view_states[SNOOP0]);

		while(1) {

board: Google Twinkie V2 #54286

board: Google Twinkie V2 #54286

Conversation

ualbertagreen commented Jan 31, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fabiobaltieri commented Feb 1, 2023 • edited Loading

fabiobaltieri left a comment

Choose a reason for hiding this comment

ualbertagreen commented Feb 23, 2023

ualbertagreen commented Jun 27, 2023

fabiobaltieri left a comment

Choose a reason for hiding this comment

fabiobaltieri commented Jul 7, 2023

ualbertagreen commented Jul 7, 2023

fabiobaltieri commented Jul 8, 2023

ualbertagreen commented Jan 31, 2023 •

edited

Loading

fabiobaltieri commented Feb 1, 2023 •

edited

Loading