tests: bsim: Bluetooth: Enable some high reliability CAP tests #80788
+163
−74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvinayak
force-pushed
the
github_tests_bsim_audio_ctlr_conf_2
branch
from
9c535d8
to
913f41d
Compare
rruuaanng
added
area: Bluetooth
area: Tests
cvinayak
force-pushed
the
github_tests_bsim_audio_ctlr_conf_2
branch
2 times, most recently
from
0e48d6e
to
d05a193
Compare
zephyrbot
added
area: Bluetooth Controller
area: Bluetooth Audio
platform: nRF BSIM
zephyrbot
requested review from
asbjornsabo,
carlescufi,
Casper-Bonde-Bose,
fredrikdanebjer,
jhedberg,
jthm-ot,
kruithofa,
larsgk,
MariuszSkamra,
mtpr-ot,
niym-ot,
pin-zephyr,
sjanc,
Thalley and
thoh-ot
cvinayak
force-pushed
the
github_tests_bsim_audio_ctlr_conf_2
branch
from
d05a193
to
58705a3
Compare
|
Failure log snippet in CI run that is different from local run: Local run PA Sync quicker: |
cvinayak
force-pushed
the
github_tests_bsim_audio_ctlr_conf_2
branch
2 times, most recently
from
81c48ba
to
a706cf5
Compare
cvinayak
force-pushed
the
github_tests_bsim_audio_ctlr_conf_2
branch
from
33feedb
to
1edc322
Compare
Fix spurious ISO Sync Receiver stall due to uninitialised value accessed due to regression introduced by commit 64facee ("Bluetooth: controller: Stop Sync ISO ticker when establishment fails"). Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
Fix ISO Sync Receiver implementation to correctly reflect the payload number and timestamp. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
Fix ISO Sync Receiver time reservation calculation to use peer broadcasted bis_spacing and sub_interval, instead of incorrectly calculating using local implementation used tMSS value. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
Remove a duplicated advertising set in the CAP acceptor babblesim test. The advertising set is configured in test_start_adv. Signed-off-by: Emil Gydesen <[email protected]>
These tests have been seen failing in CI due to the real time execution timeout. Let's increase it so it does not happen. Signed-off-by: Alberto Escolar Piedras <[email protected]>
Align audio test Controller Kconfig value same as used with nRF53bsim. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
cvinayak
force-pushed
the
github_tests_bsim_audio_ctlr_conf_2
branch
from
1edc322
to
c133cd2
Compare
Enable some high reliability CAP tests by increasing ISO Tx buffer counts in the Controller to sufficiently generate number of complete when multiple SDUs are transmitted in single ISO interval with use of pre-transmissions. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
cvinayak
force-pushed
the
github_tests_bsim_audio_ctlr_conf_2
branch
from
c133cd2
to
4950663
Compare
Thalley
reviewed
Nov 5, 2024
There was a problem hiding this comment.
Since these test scripts are already taking a long time to finish given the many test cases in each of them, we should consider either running them in parallel in this script somehow, or split the files.
We could either split them like
AC_14_8 -> Run all 8_x_x tests
AC_14_16 -> Run all 16_x_x tests
AC_14_24 -> Run all 24_x_x tests
etc.
or split them by high and light reliability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable some high reliability CAP tests by increasing ISO Tx buffer counts in the Controller to sufficiently generate number of complete when multiple SDUs are transmitted in single ISO interval with use of pre-transmissions.
Includes #80775.
Includes #80691.Fixes #80734.
Fixes #80682.