drivers: flash: fix RWW issues in flash_mcux_flexspi_hyperflash #88469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't access device pointer from critical sections when programming the hyperflash, as this could cause a RWW hazard Signed-off-by: Daniel DeGrasse <[email protected]>
github-actions
bot
added
area: Flash
platform: NXP Drivers
github-actions
bot
requested review from
dbaluta,
de-nordic,
decsny,
dleach02,
manuargue,
mmahadevan108,
Raymond0225 and
rghaddab
danieldegrasse
force-pushed
the
fix/rt1050-hyperflash
branch
from
88bbf06 to
7f23e09
Compare
pdgendt
reviewed
Apr 11, 2025
Comment on lines
424
to
425
| L1CACHE_DisableICache(); | ||
| L1CACHE_DisableDCache(); |
There was a problem hiding this comment.
Shouldn't you use the sys_cache_ functions instead? In case the CACHE_MANAGEMENT is turned off completely?
There was a problem hiding this comment.
Yeah, probably best to get this conversion done. Changed to use sys_cache* functions in latest push
butok
previously approved these changes
Apr 14, 2025
danieldegrasse
changed the title
Disable the cache during erase and programming operations, as cache pre-fetch operations can cause flash access outside of the application's control Also, reduce the SCLK frequency used after erase operations to 200MHz. Without this, the RT1050 appears to hang after flash program operations Signed-off-by: Daniel DeGrasse <[email protected]>
danieldegrasse
force-pushed
the
fix/rt1050-hyperflash
branch
from
7f23e09 to
d3bcc61
Compare
|
NXP specific, re-assigned to @mmahadevan108. |
pdgendt
approved these changes
Apr 15, 2025
|
@mmahadevan108 can you take a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply a few fixes to the NXP FlexSPI hyperflash driver to prevent flash read access from the core while programming the flash. These fixes were tested with #85254 on an RT1050-EVK, as this is where I encountered the crashes.
Note that the ICACHE/DCACHE disable step is based on what is done here: https://github.com/nxp-mcuxpresso/mcux-sdk-examples/blob/52b428258efda7d5bd8a2ace2195ca828356743a/evkbimxrt1050/driver_examples/flexspi/hyper_flash/polling_transfer/flexspi_hyper_flash_ops.c#L279