Correct required condition. (#17)

Co-authored-by: david_smith <[email protected]>
zero-to-prod · Nov 12, 2024 · f9c4336 · f9c4336
1 parent f91758d
commit f9c4336
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/README.md b/README.md
@@ -459,6 +459,7 @@ class User
         'protocols' => ['http', 'udp'], // Optional. Defaults to all.
         'on_fail' => [MyAction::class, 'method'], // Optional. Invoked when validation fails.
         'exception' => InvalidUrlException::class, // Optional. Throws an exception when not url.
+        'required'  // Optional. Throws \Zerotoprod\DataModel\PropertyRequiredException::class
     ])]
     public string $url;
 }

diff --git a/src/DataModelHelper.php b/src/DataModelHelper.php
@@ -133,8 +133,8 @@ public static function isUrl(mixed $value, array $context, ?ReflectionAttribute
             return null;
         }
 
-        if (!$value || in_array('required', $args, true)) {
-            throw new PropertyRequiredException("Property `\${$Property->getName()}` is required");
+        if (!$value && in_array('required', $args, true)) {
+            throw new PropertyRequiredException("Property `\${$Property->getName()}` is required.");
         }
 
         if (!is_string($value)) {

diff --git a/tests/Unit/IsUrl/Required/RequiredTest.php b/tests/Unit/IsUrl/Required/RequiredTest.php
@@ -11,6 +11,7 @@ class RequiredTest extends TestCase
     #[Test] public function required(): void
     {
         $this->expectException(PropertyRequiredException::class);
+        $this->expectExceptionMessage('Property `$url` is required.');
         User::from();
     }