simpler pch support for zig build #20879
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #17956 (included here as well), that exposes a simpler interface to use precompiled headers.
It is now possible to simply add the name of the header file to precompile:
In order to do this,
finalize()
function to the build steps,I don't know if that fits the general design of the build system or if there's an other way to achieve this.
updated example patch for https://github.com/allyourcodebase/cpython: