Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nail down transformation matrix convention #265

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

csu-bot-zivid
Copy link
Contributor

@csu-bot-zivid csu-bot-zivid commented Aug 6, 2024

This commit modifies variable names of transformation matrices.
The naming is based on the convention explained at:
https://support.zivid.com/en/latest/reference-articles/position-orientation-coordinate-transform.html

@SatjaSivcev SatjaSivcev changed the title Samples: Automatic updates to public repository Nail down transformation matrix convention Aug 7, 2024
@SatjaSivcev SatjaSivcev force-pushed the 2024-08-06-update-cpp-samples branch from ce939d1 to c81dd99 Compare August 7, 2024 07:51
Copy link
Contributor

@SatjaSivcev SatjaSivcev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@csu-bot-zivid csu-bot-zivid force-pushed the 2024-08-06-update-cpp-samples branch 2 times, most recently from 3f7bb42 to a94aa0a Compare August 16, 2024 18:31
@csu-bot-zivid csu-bot-zivid force-pushed the 2024-08-06-update-cpp-samples branch 3 times, most recently from e21bb17 to 059a034 Compare August 25, 2024 17:12
@csu-bot-zivid csu-bot-zivid force-pushed the 2024-08-06-update-cpp-samples branch 2 times, most recently from 96f160d to a750e72 Compare September 2, 2024 17:59
@csu-bot-zivid csu-bot-zivid force-pushed the 2024-08-06-update-cpp-samples branch 4 times, most recently from e452c71 to 48a51ff Compare September 13, 2024 20:57
@csu-bot-zivid csu-bot-zivid force-pushed the 2024-08-06-update-cpp-samples branch 3 times, most recently from 904df46 to 4c4b887 Compare September 20, 2024 21:08
@csu-bot-zivid csu-bot-zivid force-pushed the 2024-08-06-update-cpp-samples branch 4 times, most recently from 9b0a150 to a009261 Compare October 4, 2024 21:00
@csu-bot-zivid csu-bot-zivid force-pushed the 2024-08-06-update-cpp-samples branch 2 times, most recently from 6983f3c to c0a9504 Compare October 12, 2024 15:22
@csu-bot-zivid csu-bot-zivid force-pushed the 2024-08-06-update-cpp-samples branch 4 times, most recently from 6a49184 to b583776 Compare October 29, 2024 09:37
Remember to do the following:
    1. Ensure that modified/deleted/new files are correct
    2. Make this commit message relevant for the changes
    3. Force push
    4. Delete branch after PR is merged

If this commit is an update from one SDK version to another,
make sure to create a release tag for previous version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants