Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Matter labs audit fixes #50

Merged
merged 44 commits into from
Oct 25, 2024
Merged

Matter labs audit fixes #50

merged 44 commits into from
Oct 25, 2024

Conversation

JohnGuilding
Copy link
Collaborator

No description provided.

@JohnGuilding JohnGuilding marked this pull request as ready for review October 19, 2024 09:15
@SoraSuegami
Copy link
Contributor

@JohnGuilding
When you merge this PR, could you keep this branch because some people might refer to it?

Base automatically changed from feat/test-improvements to feat/body-parsing October 21, 2024 06:25
JohnGuilding and others added 21 commits October 21, 2024 13:28
@JohnGuilding
add guardian vote check & recovery hash to weight storage WIP
202104f
@SoraSuegami @JohnGuilding
Improve RecoveryRequest
d4b51af
@SoraSuegami @JohnGuilding
Fix all unit tests
5b49409
@wshino @JohnGuilding
Feat/script tests (#49)
5cafa83 
* Remove email-wallet-sdk

* Update package version

* Update README

* Update pnpm commands

* Add tests for scripts

* Add threads = 1 to foundry.toml
@JohnGuilding
Prevent malicious guardians threatening liveness via cooldown
130f154
@JohnGuilding
Uncomment all test assertions & use EnumerableSet
236b90f
@JohnGuilding
Update processRecovery tests
1046138
@JohnGuilding
Add remaining tests from TODOs & add getter fn
a4cfd23
@JohnGuilding
Update existing assertions with new state
f78efe7
@JohnGuilding
Add getAllGuardians getter function
8b3e35a
@JohnGuilding
Make getter function view
c172968
@JohnGuilding
10 Critical events are not observable
77d64f6
@JohnGuilding
Return false for canStartRecoveryRequest when threshold is zero
1d103f9
@JohnGuilding
Update ether-email-auth
0b9b265
@SoraSuegami @JohnGuilding
Update package version
bda3913
@JohnGuilding
10. EmailRecoveryContract is not compatible with zkSync
4f7612a
@JohnGuilding
clearRecoveryRequest properly in deinit
b32da71
@SoraSuegami @JohnGuilding
Update ether-email-auth-contracts
ad01b4b
@SoraSuegami @JohnGuilding
Update version to 0.0.10
e1fec89
@JohnGuilding
Update natpsec
f540589
@JohnGuilding
test-nexus-account
e4faf85
@openzeppelin-code OpenZeppelin Code
Copy link

openzeppelin-code bot commented Oct 22, 2024 •
edited
Loading

Matter labs audit fixes

Generated at commit: aa9ce5c0859ecf59dd375bb83e6ef71a5c6cca41

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 0
1
0
4
16
21
Dependencies Critical
High
Medium
Low
Note
Total		 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@SoraSuegami SoraSuegami merged commit aa9ce5c into feat/body-parsing Oct 25, 2024
7 checks passed
@SoraSuegami SoraSuegami deleted the matter-labs-audit-fixes branch October 25, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wshino wshino wshino approved these changes

@SoraSuegami SoraSuegami SoraSuegami approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JohnGuilding @SoraSuegami @wshino