Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Matter labs audit fixes #50

Merged
merged 44 commits into from
Oct 25, 2024
Merged

Matter labs audit fixes #50

merged 44 commits into from
Oct 25, 2024

Commits on Oct 21, 2024

  1. add guardian vote check & recovery hash to weight storage WIP

    @JohnGuilding
    JohnGuilding committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    202104f View commit details
    Browse the repository at this point in the history

  2. Improve RecoveryRequest

    @SoraSuegami @JohnGuilding
    SoraSuegami authored and JohnGuilding committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    d4b51af View commit details
    Browse the repository at this point in the history

  3. Fix all unit tests

    @SoraSuegami @JohnGuilding
    SoraSuegami authored and JohnGuilding committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    5b49409 View commit details
    Browse the repository at this point in the history

  4. Feat/script tests (#49) 

    * Remove email-wallet-sdk

* Update package version

* Update README

* Update pnpm commands

* Add tests for scripts

* Add threads = 1 to foundry.toml
    @wshino @JohnGuilding
    wshino authored and JohnGuilding committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    5cafa83 View commit details
    Browse the repository at this point in the history

  5. Prevent malicious guardians threatening liveness via cooldown

    @JohnGuilding
    JohnGuilding committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    130f154 View commit details
    Browse the repository at this point in the history

  6. Uncomment all test assertions & use EnumerableSet

    @JohnGuilding
    JohnGuilding committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    236b90f View commit details
    Browse the repository at this point in the history

  7. Update processRecovery tests

    @JohnGuilding
    JohnGuilding committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    1046138 View commit details
    Browse the repository at this point in the history

  8. Add remaining tests from TODOs & add getter fn

    @JohnGuilding
    JohnGuilding committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    a4cfd23 View commit details
    Browse the repository at this point in the history

  9. Update existing assertions with new state

    @JohnGuilding
    JohnGuilding committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    f78efe7 View commit details
    Browse the repository at this point in the history

  10. Add getAllGuardians getter function

    @JohnGuilding
    JohnGuilding committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    8b3e35a View commit details
    Browse the repository at this point in the history

  11. Make getter function view

    @JohnGuilding
    JohnGuilding committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    c172968 View commit details
    Browse the repository at this point in the history

  12. 10 Critical events are not observable

    @JohnGuilding
    JohnGuilding committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    77d64f6 View commit details
    Browse the repository at this point in the history

  13. Return false for canStartRecoveryRequest when threshold is zero

    @JohnGuilding
    JohnGuilding committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    1d103f9 View commit details
    Browse the repository at this point in the history

  14. Update ether-email-auth

    @JohnGuilding
    JohnGuilding committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    0b9b265 View commit details
    Browse the repository at this point in the history

  15. Update package version

    @SoraSuegami @JohnGuilding
    SoraSuegami authored and JohnGuilding committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    bda3913 View commit details
    Browse the repository at this point in the history

  16. 10. EmailRecoveryContract is not compatible with zkSync

    @JohnGuilding
    JohnGuilding committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    4f7612a View commit details
    Browse the repository at this point in the history

  17. clearRecoveryRequest properly in deinit

    @JohnGuilding
    JohnGuilding committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    b32da71 View commit details
    Browse the repository at this point in the history

  18. Update ether-email-auth-contracts

    @SoraSuegami @JohnGuilding
    SoraSuegami authored and JohnGuilding committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    ad01b4b View commit details
    Browse the repository at this point in the history

  19. Update version to 0.0.10

    @SoraSuegami @JohnGuilding
    SoraSuegami authored and JohnGuilding committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    e1fec89 View commit details
    Browse the repository at this point in the history

  20. Update natpsec

    @JohnGuilding
    JohnGuilding committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    f540589 View commit details
    Browse the repository at this point in the history

  21. test-nexus-account

    @JohnGuilding
    JohnGuilding committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    e4faf85 View commit details
    Browse the repository at this point in the history

  22. Run tests with different command handlers

    @JohnGuilding
    JohnGuilding committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    05978a8 View commit details
    Browse the repository at this point in the history

  23. Rename

    @JohnGuilding
    JohnGuilding committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    3b282f1 View commit details
    Browse the repository at this point in the history

  24. Add fuzz tests for hexToBytes32 unit tests

    @JohnGuilding
    JohnGuilding committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    173afe5 View commit details
    Browse the repository at this point in the history

  25. Add tests for AccountHidingRecoveryCommandHandler

    @JohnGuilding
    JohnGuilding committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    a8aadf3 View commit details
    Browse the repository at this point in the history

  26. Add safe module unit tests

    @JohnGuilding
    JohnGuilding committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    8f9944f View commit details
    Browse the repository at this point in the history

  27. fuzz test getPreviousOwnerInLinkedList

    @JohnGuilding
    JohnGuilding committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    e1d9fcd View commit details
    Browse the repository at this point in the history

  28. Add missing low risk functions

    @wshino @JohnGuilding
    wshino authored and JohnGuilding committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    32e2951 View commit details
    Browse the repository at this point in the history

  29. Add script for account hiding

    @wshino @JohnGuilding
    wshino authored and JohnGuilding committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    7d4dedb View commit details
    Browse the repository at this point in the history

  30. Add the section which is how to solve errrors

    @wshino @JohnGuilding
    wshino authored and JohnGuilding committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    b3a3960 View commit details
    Browse the repository at this point in the history

  31. Merge pull request #51 from zkemail/feat/more-test-cleanup-and-improv… 

    …ements

More test cleanup and improvements
    @JohnGuilding
    JohnGuilding authored Oct 21, 2024
    Configuration menu
    Copy the full SHA
    33a2090 View commit details
    Browse the repository at this point in the history

  32. Use ForwardDKIMRegistry

    @JohnGuilding
    JohnGuilding committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    51fb2be View commit details
    Browse the repository at this point in the history

  33. Remove ForwardDKIMRegistry

    @SoraSuegami
    SoraSuegami committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    742ba1b View commit details
    Browse the repository at this point in the history

  34. Fix failing tests

    @SoraSuegami
    SoraSuegami committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    f062ebf View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. revert to all github workflows without nexus account

    @JohnGuilding
    JohnGuilding committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    f1d34cf View commit details
    Browse the repository at this point in the history

  2. 13 EmailRecoveryManager delay can be set to zero

    @JohnGuilding
    JohnGuilding committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    a0fb8c4 View commit details
    Browse the repository at this point in the history

  3. Fix failing test

    @JohnGuilding
    JohnGuilding committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    3f78120 View commit details
    Browse the repository at this point in the history

  4. Fix lock file

    @SoraSuegami
    SoraSuegami committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    52f258b View commit details
    Browse the repository at this point in the history

  5. Recover lock file

    @SoraSuegami
    SoraSuegami committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    629312c View commit details
    Browse the repository at this point in the history

  6. Change workflow

    @SoraSuegami
    SoraSuegami committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    63d56ac View commit details
    Browse the repository at this point in the history

  7. Fix MockGroth16Verifier

    @SoraSuegami
    SoraSuegami committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    3b239c4 View commit details
    Browse the repository at this point in the history

  8. Update depndency

    @SoraSuegami
    SoraSuegami committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    034b82f View commit details
    Browse the repository at this point in the history

  9. Specify npm package of ether-email-auth

    @SoraSuegami
    SoraSuegami committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    97d8287 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2024

  1. Use salt value for deployment (#55) 

    * Use salt value for deployment

* Add minimumDelay

* Add CREATE2_SALT value into all deploy scripts
    @wshino
    wshino authored Oct 25, 2024
    Configuration menu
    Copy the full SHA
    aa9ce5c View commit details
    Browse the repository at this point in the history