Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log during activation instead of showing popup #127

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Conversation

rudyflores
Copy link
Contributor

What It Does

Displays the old Zowe Explorer was modified for the CICS Extension. in the log instead of in a popup.

How to Test

Package and install extension, and when opening ZE should not show popup anymore.

Review Checklist
I certify that I have:

Additional Comments

@rudyflores rudyflores requested a review from zFernand0 May 8, 2024 20:52
@rudyflores rudyflores self-assigned this May 8, 2024
@rudyflores
Copy link
Contributor Author

@zFernand0 once merged, i'll cherry-pick the commits to the other to branches :)

@codecov-commenter
Copy link

codecov-commenter commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.28%. Comparing base (aeee0bd) to head (936b623).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #127   +/-   ##
=======================================
  Coverage   93.28%   93.28%           
=======================================
  Files          74       74           
  Lines         760      760           
  Branches       93       93           
=======================================
  Hits          709      709           
  Misses         51       51           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Rudy Flores <[email protected]>
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes make sense. 👍🏽

However, we need to initialize the logger, otherwise no logs are being printed out.

{
 "mJsLogger":
  { 
   "category":"app", 
   "context": {} 
  },
 "category":"app",
 "initStatus":false
}

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay on this. ☔
These changes do achieve the intended goal of the PR description. 😋
LGTM! 😋

@zFernand0 zFernand0 merged commit 49aadd9 into main Jun 20, 2024
18 of 19 checks passed
@zFernand0 zFernand0 deleted the log-instead-of-popup branch June 20, 2024 13:52
@zFernand0 zFernand0 added the release-current Indicates that there is no new functionality being delivered label Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog release-current Indicates that there is no new functionality being delivered
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants