Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log during activation instead of showing popup #127

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Log during activation instead of showing popup #127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eade23d
Log during activation instead of showing popup
rudyflores May 8, 2024
936b623
Add CHANGELOG.md
rudyflores May 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/vsce/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ All notable changes to the "cics-extension-for-zowe" extension will be documente
## `2.3.6`

- BugFix: Fixed several identified problems with possible null values in the tree and web views. [#121](https://github.com/zowe/cics-for-zowe-client/issues/121)
- Moved the popup from activation `Zowe Explorer was modified for the CICS Extension.` to the logger instead.

## `2.3.5`

Expand Down
6 changes: 4 additions & 2 deletions packages/vsce/src/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ import { getZoweExplorerVersion } from "./utils/workspaceUtils";
import { getInquireTransactionCommand } from "./commands/inquireTransaction";
import { getPurgeTaskCommand } from "./commands/purgeTaskCommand";
import { getInquireProgramCommand } from "./commands/inquireProgram";
import { Logger } from "@zowe/imperative";

/**
* Initialises extension
Expand All @@ -85,6 +86,7 @@ import { getInquireProgramCommand } from "./commands/inquireProgram";
*/
export async function activate(context: ExtensionContext) {
const zeVersion = getZoweExplorerVersion();
const logger = Logger.getAppLogger();
let treeDataProv: CICSTree = null;
if (!zeVersion) {
window.showErrorMessage("Zowe Explorer was not found: Please ensure Zowe Explorer v2.0.0 or higher is installed");
Expand All @@ -105,10 +107,10 @@ export async function activate(context: ExtensionContext) {
await treeDataProv.refreshLoadedProfiles();
});
}
window.showInformationMessage("Zowe Explorer was modified for the CICS Extension.");
logger.debug("Zowe Explorer was modified for the CICS Extension.");
} catch (error) {
console.log(error);
window.showErrorMessage("Zowe Explorer for IBM CICS was not initiliaized correctly");
logger.error("Zowe Explorer for IBM CICS was not initiliaized correctly");
return;
}
} else {
Expand Down
Loading