Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: OVSX publishing issues #165

Merged
merged 1 commit into from
Dec 13, 2024
Merged

fix: OVSX publishing issues #165

merged 1 commit into from
Dec 13, 2024

Conversation

zFernand0
Copy link
Member

What It Does

Fixes OVSX publishing issues

How to Test

See the OVSX registry 😋

Review Checklist
I certify that I have:

Additional Comments

Sorry, something went wrong.

Signed-off-by: Fernando Rijo Cedeno <[email protected]>
@zFernand0 zFernand0 self-assigned this Dec 12, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.17%. Comparing base (c16dc0e) to head (b784cb3).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #165   +/-   ##
=======================================
  Coverage   93.17%   93.17%           
=======================================
  Files          73       73           
  Lines         718      718           
  Branches       54       55    +1     
=======================================
  Hits          669      669           
  Misses         49       49           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense to me. Thanks for the fix Fernando!

Copy link

@JillieBeanSim JillieBeanSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @zFernand0 thanks for explaining it in the call today

@zFernand0 zFernand0 merged commit 38ed66a into main Dec 13, 2024
17 checks passed
@zFernand0 zFernand0 deleted the fix-ovsx branch December 13, 2024 14:18
@zFernand0 zFernand0 added the release-current Indicates that there is no new functionality being delivered label Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog release-current Indicates that there is no new functionality being delivered
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

None yet

4 participants