Add CMCI query parameters to SDK getResource #171
Conversation
| /** | ||
| * Query parameters to be used in the HTTP request | ||
| */ | ||
| queryParams?: IResourceQueryParams; |
There was a problem hiding this comment.
I like the idea of a query parameters object.
Maybe by V4 we could move criteria and parameter to that object 😋
| if (options != null) { | ||
| if (options.criteria != null && options.criteria.length > 0) { | ||
| const addParentheses = options.criteria.charAt(0) !== '('; | ||
| if (options && options.criteria) { |
There was a problem hiding this comment.
not required to change this, but if you want to save some typing 😋
| if (options && options.criteria) { | |
| if (options?.criteria) { |
This may apply to other if conditions 🙏
| delimiter = "&"; | ||
| } | ||
|
|
||
| if (options && options.queryParams && options.queryParams.nodiscard) { |
There was a problem hiding this comment.
there could be some savings here too 😋
| if (options && options.queryParams && options.queryParams.nodiscard) { | |
| if (options?.queryParams?.nodiscard) { |
Signed-off-by: Andrew Twydell <[email protected]>
Signed-off-by: Andrew Twydell <[email protected]>
Signed-off-by: Andrew Twydell <[email protected]>
Signed-off-by: Andrew Twydell <[email protected]>
AndrewTwydell
force-pushed
the
get-resource-query-params
branch
from
f17635b to
96512f1
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| if (options && options.queryParams && options.queryParams.overrideWarningCount) { | ||
| cmciResource += `${delimiter}${CicsCmciConstants.OVERRIDE_WARNING_COUNT}`; | ||
| delimiter = "&"; |
Check warning
Code scanning / CodeQL
Useless assignment to local variable Warning
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #171 +/- ##
==========================================
+ Coverage 93.49% 93.62% +0.12%
==========================================
Files 74 74
Lines 738 753 +15
Branches 37 40 +3
==========================================
+ Hits 690 705 +15
Misses 48 48 ☔ View full report in Codecov by Sentry. |
zFernand0
added
release-minor
|
Labeled as |
What It Does
Allows a user to specify query parameters to be added to the CMCI query URI (SUMMONLY, NODISCARD, OVERRIDEWARNINGCOUNT) by adding an optional addition to the supplied params.
This will allow the VSCE to retrieve a cache token from CMCI which will enable pagination on large result sets.
Review Checklist
I certify that I have: