Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use cdk repo for erigon sequencer #193

Merged
merged 26 commits into from
Aug 6, 2024
Merged

feat: use cdk repo for erigon sequencer #193

merged 26 commits into from
Aug 6, 2024

Conversation

vcastellm
Copy link
Contributor

@vcastellm vcastellm commented Jul 24, 2024

This PR introduce a bunch of changes, running zkevm node is now optional and disabled by default.

The CI is configured for testing both zkevm-node and cdk-erigon + cdk-node while there's still production deployments of the zkevm-node.

This PR goes after 0xPolygon/cdk#4

wip

wip

wip

wip

almost working

fix config

config

wip

Tips and tricks

Default to Eldelberry

wip

fix config

Bump prover and erigon
@vcastellm vcastellm marked this pull request as ready for review July 31, 2024 14:50
lib/cdk_node.star Outdated Show resolved Hide resolved
lib/cdk_node.star Outdated Show resolved Hide resolved
lib/cdk_node.star Outdated Show resolved Hide resolved
lib/cdk_node.star Outdated Show resolved Hide resolved
templates/trusted-node/prover-config.json Show resolved Hide resolved
@leovct
Copy link
Member

leovct commented Aug 1, 2024

I'm also running the nightly workflow against your branch to check everything works.
https://github.com/0xPolygon/kurtosis-cdk/actions/runs/10202819341

edit: looks like the deployment is not working atm and you can also fix lint issues using kurtosis lint --format .

@vcastellm
Copy link
Contributor Author

Applied feedback @leovct

@vcastellm vcastellm requested a review from leovct August 2, 2024 09:59
Copy link
Member

@leovct leovct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few nits but lgtm! waiting for the deploy job to pass to approve :)

.github/workflows/deploy.yml Show resolved Hide resolved
kurtosis.yml Show resolved Hide resolved
input_parser.star Show resolved Hide resolved
params.yml Show resolved Hide resolved
Copy link

sonarcloud bot commented Aug 6, 2024

Copy link
Member

@leovct leovct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, let's see what the CI says :)

@leovct leovct changed the title Use cdk repo for erigon sequencer feat: use cdk repo for erigon sequencer Aug 6, 2024
@leovct leovct merged commit 6d3b4fe into main Aug 6, 2024
9 checks passed
@leovct leovct deleted the vcastellm/use-cdk branch August 6, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants