Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PetabObjective #962

Closed
yannikschaelte opened this issue Feb 19, 2020 · 2 comments
Closed

PetabObjective #962

yannikschaelte opened this issue Feb 19, 2020 · 2 comments
Assignees
@dweindl
Labels
enhancement PEtab PEtab-import related

Comments

@yannikschaelte
Copy link
Member

Create a class encapsulating the petab simulation functionality, in particular later allowing to cache e.g. mappings to increase efficiency.
@dweindl dweindl added the PEtab PEtab-import related label Feb 28, 2020
@dweindl dweindl removed the new Newly created label May 29, 2020
@dweindl dweindl self-assigned this Nov 29, 2023
@dweindl
Copy link
Member

dweindl commented Nov 29, 2023

Will look into that. Was thinking about some AmiciPetabProblem class that takes the model and the PEtab problem and can be used to create ExpData for the PEtab-defined conditions. Probably with some option to cache or always recreate the ExpDatas (the former would generally be faster, the latter would be more memory-efficient).

This should make it easier to simulate the model for specific conditions, in particular in interactive use.

dweindl added a commit to dweindl/AMICI that referenced this issue Jan 3, 2024
@dweindl
Add AmiciPetabProblem class for handling PEtab-defined simulation con…
0574214 
…ditions

Makes it a bit easier to work with PEtab problems interactively or when implementing some PEtab-based objective function (AMICI-dev#962).
@dweindl dweindl mentioned this issue Jan 3, 2024
Merged
dweindl added a commit to dweindl/AMICI that referenced this issue Jan 7, 2024
@dweindl
Add AmiciPetabProblem class for handling PEtab-defined simulation con…
7d23f50 
…ditions

Makes it a bit easier to work with PEtab problems interactively or when implementing some PEtab-based objective function (AMICI-dev#962).
dweindl added a commit that referenced this issue Jan 16, 2024
@dweindl @FFroehlich
Add PetabProblem class for handling PEtab-defined simulation con… (#2255
2f7aaf4 
)

…ditions

Makes it a bit easier to work with PEtab problems interactively or when implementing some PEtab-based objective function (#962).

---------

Co-authored-by: Fabian Fröhlich <[email protected]>
@dweindl
Copy link
Member

dweindl commented Sep 28, 2024

Closed by #2255

@dweindl dweindl closed this as completed Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dweindl dweindl

Labels
enhancement PEtab PEtab-import related
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dweindl @yannikschaelte