Add PetabProblem class for handling PEtab-defined simulation con… #2255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #2255 +/- ##
===========================================
+ Coverage 77.04% 77.16% +0.11%
===========================================
Files 92 94 +2
Lines 14987 15085 +98
===========================================
+ Hits 11547 11640 +93
- Misses 3440 3445 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…ditions Makes it a bit easier to work with PEtab problems interactively or when implementing some PEtab-based objective function (AMICI-dev#962).
dweindl
force-pushed
the
amici_petab_problem
branch
from
596a372 to
f2f0d12
Compare
dweindl
force-pushed
the
amici_petab_problem
branch
from
2a4d2ab to
9ab1463
Compare
dweindl
changed the title
FFroehlich
approved these changes
Jan 16, 2024
| "scaled_parameters=True in combination with default " | ||
| "parameters is not implemented yet." | ||
| ) | ||
| scaled_parameters = False |
| from .parameter_mapping import create_parameter_mapping | ||
|
|
||
|
|
||
| class PetabProblem: |
There was a problem hiding this comment.
why is codecov not reporting any coverage here?
There was a problem hiding this comment.
Oops. Because I started putting tests in a separate PEtab directory which was not included in the pytest invocation.
Co-authored-by: Fabian Fröhlich <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ditions
Makes it a bit easier to work with PEtab problems interactively or when implementing some PEtab-based objective function (#962).