feat(cosmos): fold in b:enable-orchestration
#10027
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelfig
force-pushed
the
mfig-enable-orchestration
branch
from
80f10ab
to
c2a4ef9
Compare
Deploying agoric-sdk with
|
| Latest commit: |
834a7f8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://64928a95.agoric-sdk.pages.dev |
| Branch Preview URL: | https://mfig-enable-orchestration.agoric-sdk.pages.dev |
michaelfig
force-pushed
the
mfig-enable-orchestration
branch
14 times, most recently
from
6af8ca9
to
34ae743
Compare
This comment was marked as outdated.
This comment was marked as outdated.
michaelfig
force-pushed
the
mfig-enable-orchestration
branch
from
34ae743
to
6b45090
Compare
michaelfig
force-pushed
the
mfig-enable-orchestration
branch
5 times, most recently
from
3458516
to
4c3eda0
Compare
michaelfig
changed the title
michaelfig
changed the title
b:enable-orchestration
turadg
requested changes
Sep 6, 2024
michaelfig
force-pushed
the
mfig-enable-orchestration
branch
from
4c3eda0
to
85ffd8d
Compare
michaelfig
force-pushed
the
mfig-docker-depot
branch
from
8817440
to
a083021
Compare
michaelfig
force-pushed
the
mfig-enable-orchestration
branch
from
85ffd8d
to
0da6ceb
Compare
michaelfig
changed the title
b:enable-orchestrationb:enable-orchestration
turadg
approved these changes
Sep 6, 2024
a3p-integration/debug-current.sh
Outdated
|
|
||
| scripts/build-submission.sh proposals/b:enable-orchestration testing/start-valueVow.js start-valueVow | ||
| scripts/build-submission.sh proposals/b:enable-orchestration testing/restart-valueVow.js restart-valueVow | ||
| scripts/build-submission.sh proposals/f:test-orchestration testing/start-valueVow.js start-valueVow |
There was a problem hiding this comment.
doesn't exist now but doesn't hurt either
michaelfig
force-pushed
the
mfig-enable-orchestration
branch
2 times, most recently
from
93410ce
to
ede6b02
Compare
michaelfig
force-pushed
the
mfig-docker-depot
branch
from
a083021
to
02aa9e2
Compare
mhofman
reviewed
Sep 7, 2024
golang/cosmos/app/upgrade.go
Outdated
Comment on lines
95
to
106
| vm.CoreProposalStepForModules( | ||
| // Upgrade to new liveslots for repaired vow usage. | ||
| "@agoric/builders/scripts/vats/upgrade-orch-core.js", | ||
| // Upgrade to new liveslots and support vows. | ||
| "@agoric/builders/scripts/smart-wallet/build-wallet-factory2-upgrade.js", | ||
| // Create vat-orchestration. | ||
| "@agoric/builders/scripts/vats/init-orchestration.js", | ||
| ), |
There was a problem hiding this comment.
Is it ok for these to run concurrently instead of separate steps?
Comment on lines
12
to
19
| "@agoric/internal": "0.3.3-dev-5676146.0", | ||
| "@agoric/synthetic-chain": "^0.1.0", | ||
| "@cosmjs/stargate": "^0.32.3", | ||
| "@cosmjs/tendermint-rpc": "^0.32.3", | ||
| "@endo/errors": "^1.2.2", | ||
| "@endo/far": "^1.0.4", | ||
| "@endo/init": "^1.0.4", | ||
| "agoric": "0.21.2-dev-5676146.0", |
There was a problem hiding this comment.
I didn't realize we had dependencies from a3p onto agoric-sdk (besides the bundles being generated). I'm wondering if there isn't a better way to handle this than previously published sdk dev versions. Would a relative path work here? Or a workspace link?
michaelfig
force-pushed
the
mfig-docker-depot
branch
2 times, most recently
from
82c3e3f
to
e7fb573
Compare
michaelfig
force-pushed
the
mfig-enable-orchestration
branch
from
ede6b02
to
57e280d
Compare
|
Base branch is changed to master. Please re-run the integration tests by adding 'force:integration' label. |
michaelfig
force-pushed
the
mfig-enable-orchestration
branch
from
57e280d
to
3fb2db8
Compare
michaelfig
force-pushed
the
mfig-enable-orchestration
branch
from
3fb2db8
to
ff310f4
Compare
fixes a property override problem with SES
turadg
force-pushed
the
mfig-enable-orchestration
branch
from
ff310f4
to
8caac2d
Compare
|
@michaelfig if we're pressed for time I approve this one. But I think I've got it green without disabling the test, |
mergify bot
added a commit
that referenced
this pull request
Sep 10, 2024
closes: #10026 ## Description Merge the `enable-orchestration` proposal with `upgrade.go` for `agoric-upgrade-17`. Variant of #10027 without disabling tests. ### Security Considerations n/a ### Scaling Considerations Performs more work at upgrade time rather than when the chain is running. ### Documentation Considerations n/a ### Testing Considerations Consolidates z:acceptance ### Upgrade Considerations Reduces voter fatigue by combining core evals.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #10026
Description
Merge the
enable-orchestrationproposal withupgrade.goforagoric-upgrade-17.Security Considerations
n/a
Scaling Considerations
Performs more work at upgrade time rather than when the chain is running.
Documentation Considerations
n/a
Testing Considerations
n/a
Upgrade Considerations
Reduces voter fatigue by combining core evals.