Scripting promote video-stream-information to an applet #28780
+318
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertlong13
reviewed
Dec 2, 2024
Hwurzburg
previously requested changes
Dec 2, 2024
rmackay9
dismissed
Hwurzburg’s stale review
HenryW's requests addressed, thanks for the review!
rmackay9
force-pushed
the
scripting-video-stream-information-easy
branch
from
63e4a30
to
1924237
Compare
rmackay9
force-pushed
the
scripting-video-stream-information-easy
branch
from
1924237
to
4ea1cf7
Compare
tridge
reviewed
Dec 4, 2024
|
|
||
| # Parameters | ||
|
|
||
| -- VID1_CAMMODEL: Video stream camera model (1:Siyi A8, 2:Siyi ZR10, 3:Siyi ZR30, 4:Siyi ZT30 Zoom, 5:Siyi ZT30 Wide, 6:Siyi ZT30 IR, 7:Siyi ZT6 RGB, 8:Siyi ZT6 IR) |
There was a problem hiding this comment.
doesn't look right in view file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enhances the set_VIDEO_STREAM_INFORMATION.lua to make it usable without any code changes by at least some users. The script is also promoted to an applet
The purpose of this script is to give the AP_Camera library the information it needs so that it can send VIDEO_STREAM_INFORMATION mavlink messages to the ground station so that it can display the live video stream to the user
15 new parameters have been added prefixed with VID1_ that allow the user to set nearly all fields of the VIDEO_STREAM_INFORMATION but for most users all they will only need to set these six:
This has been successfully tested with the Siyi A8, ZR10 and ZT6 cameras and Mission Planner's new gimbal interface
Enhancements coming in future PRs: